Update vert.x to 3.9.6

[larsnaesbye]

Addresses first part of gravitee-io/issues#4095

[aelamrani]

Hi @larsnaesbye

This fix does not close completely the issue as it is just an upgrade on the parent.

Did you process some tests on the gateway?

[larsnaesbye]

Good point. We'll need to make a new parent version and then update it in the gateway pom.xml afterwards :-)

I changed the description.

[larsnaesbye]

I changed the dependency version to 3.9.1 and ran the gateway Maven test command - all successful.

[INFO] Reactor Summary for Gravitee.io APIM - Gateway 3.4.0-SNAPSHOT:
[INFO] 
[INFO] Gravitee.io APIM - Gateway ......................... SUCCESS [  3.259 s]
[INFO] Gravitee.io APIM - Gateway - Environment ........... SUCCESS [ 10.193 s]
[INFO] Gravitee.io APIM - Gateway - Buffer implementation . SUCCESS [  2.285 s]
[INFO] Gravitee.io APIM - Gateway - Core .................. SUCCESS [ 14.697 s]
[INFO] Gravitee.io APIM - Gateway - Reporting ............. SUCCESS [  2.558 s]
[INFO] Gravitee.io APIM - Gateway - Reactor ............... SUCCESS [ 13.153 s]
[INFO] Gravitee.io APIM - Gateway - Repository ............ SUCCESS [  1.617 s]
[INFO] Gravitee.io APIM - Gateway - Resource .............. SUCCESS [ 10.697 s]
[INFO] Gravitee.io APIM - Gateway - Policy ................ SUCCESS [ 18.140 s]
[INFO] Gravitee.io APIM - Gateway - Dictionary ............ SUCCESS [  2.225 s]
[INFO] Gravitee.io APIM - Gateway - HTTP Support .......... SUCCESS [ 16.165 s]
[INFO] Gravitee.io APIM - Gateway - Security .............. SUCCESS [  0.369 s]
[INFO] Gravitee.io APIM - Gateway - Security - Core ....... SUCCESS [ 12.549 s]
[INFO] Gravitee.io APIM - Gateway - Security - API Key .... SUCCESS [ 15.798 s]
[INFO] Gravitee.io APIM - Gateway - Security - Keyless .... SUCCESS [ 11.868 s]
[INFO] Gravitee.io APIM - Gateway - Security - OAuth2 ..... SUCCESS [ 20.091 s]
[INFO] Gravitee.io APIM - Gateway - Security - JWT ........ SUCCESS [ 11.902 s]
[INFO] Gravitee.io APIM - Gateway - Reactor Handlers ...... SUCCESS [  0.134 s]
[INFO] Gravitee.io APIM - Gateway - Reactor Handlers - API  SUCCESS [ 34.444 s]
[INFO] Gravitee.io APIM - Gateway - Standalone ............ SUCCESS [  0.292 s]
[INFO] Gravitee.io APIM - Gateway - Standalone - Container  SUCCESS [ 55.898 s]
[INFO] Gravitee.io APIM - Gateway - Standalone - Bootstrap  SUCCESS [  0.519 s]
[INFO] Gravitee.io APIM - Gateway - Services .............. SUCCESS [  0.567 s]
[INFO] Gravitee.io APIM - Gateway - Services - Health Check SUCCESS [ 36.780 s]
[INFO] Gravitee.io APIM - Gateway - Services - Sync ....... SUCCESS [ 23.266 s]
[INFO] Gravitee.io APIM - Gateway - Services - Local Registry SUCCESS [ 18.146 s]
[INFO] Gravitee.io APIM - Gateway - Services - API Keys cache SUCCESS [ 20.190 s]
[INFO] Gravitee.io APIM - Gateway - Services - Hearbeat ... SUCCESS [  3.119 s]
[INFO] Gravitee.io APIM - Gateway - Services - Endpoints Discovery SUCCESS [  8.455 s]
[INFO] Gravitee.io APIM - Gateway - Services - Subscriptions cache SUCCESS [  8.298 s]
[INFO] Gravitee.io APIM - Gateway - Standalone - Distribution SUCCESS [  0.049 s]
[INFO] Gravitee.io APIM - Gateway - Standalone - Distribution - ZIP SUCCESS [  0.017 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

[larsnaesbye]

I don't know how to verify @tapiiron 's issue being solved, as it is not described how to reproduce.

[tapiiron]

Vert.x seems to have just released 3.9.4 . As it is used in gravitee gw engine, fixes in the vertx project will fix possible issues in gravitee gw. That is why added the update request :)

[larsnaesbye]

There are a bunch of HTTP-related fixes in the release notes up to 3.9.1 alright. I ran the Maven test and IntelliJ code inspection - no obvious problems.

[larsnaesbye]

It looks as if it's safe enough to merge. Of course we'll only ever find out for certain when the projects use the next release.

[larsnaesbye]

@tapiiron it seems like Vert.x 4 is going to find its way into Gravitee eventually, but the upgrade path goes via 3.9.x. Currently we are at 3.9.6.

The 3.9.x branch seems to have indeed fixed quite a bit of bugs, like NPEs and some CVEs especially via dependency updates like Netty. The GraphQL stuff also looks good.

[larsnaesbye]

@phiz71
Should we go for 3.9.6 right away? (I will just change it and squash commits)
Also, since 3.9.1 and newer reference a newer Netty version (4.1.49.Final), should we upgrade to this version too so they are in sync?

[brasseld]

Hi @larsnaesbye

Yes, we have to keep those dependencies in sync.

So we'll certainly upgrade vertx, netty and jackson.

Regards,

[tcompiegne]

Hi @larsnaesbye,

Can you upgrade to the latest Vert.x 3.9.6 version ?

Kind regards

[larsnaesbye]

Done :-)

I would like to squash, but I'm uncertain how to do this with remote and already pushed commits.

[larsnaesbye]

Interactive rebase and force push seemed to work anyway :-)

[brasseld]

We have moved to Vert.x 4.1 starting from Gravitee 3.10