Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep all values of multivalued headers #24

Merged
merged 3 commits into from Jun 27, 2023
Merged

Keep all values of multivalued headers #24

merged 3 commits into from Jun 27, 2023

Conversation

gaetanmaisse
Copy link
Contributor

@gaetanmaisse gaetanmaisse commented Jun 26, 2023 •
edited by graviteeio

Issue

https://gravitee.atlassian.net/browse/APIM-1906
gravitee-io/issues#9085

Description

Keep all values of multivalued headers instead of keeping only the last one

Gravitee.io Automatic Deployment

🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

  • use it directly by updating your project with version: 1.5.1-APIM-1906-multivalue-headers-SNAPSHOT
  • download it from Artifactory here

@gaetanmaisse gaetanmaisse marked this pull request as ready for review June 26, 2023 16:42
@gaetanmaisse gaetanmaisse requested review from a team as code owners June 26, 2023 16:42
ytvnr
ytvnr approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@ytvnr ytvnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
I wonder if it's not the opportunity to move the pattern compilation from line 124 to the constructor.
Do you think it worth writing an Integration Test (with more than one header so we are sure to preserve the rest of the headers)
wdyt ?

@gaetanmaisse gaetanmaisse merged commit c86d73b into master Jun 27, 2023
8 of 9 checks passed
@gaetanmaisse gaetanmaisse deleted the APIM-1906-multivalue-headers branch June 27, 2023 08:59
@graviteeio
Copy link
Contributor

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytvnr ytvnr ytvnr approved these changes

@remibaptistegio remibaptistegio remibaptistegio approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
4 participants
@gaetanmaisse @graviteeio @ytvnr @remibaptistegio