Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MQTT5.x] Improve security choice #9173

Closed
exalate-issue-sync bot opened this issue Aug 7, 2023 · 1 comment
Closed

[MQTT5.x] Improve security choice #9173

exalate-issue-sync bot opened this issue Aug 7, 2023 · 1 comment

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Aug 7, 2023

Description

Currently, MQTT 5.x endpoint has its security choice defined as an anyOf in schema-form.json.

According to schema-form documentation: A schema with anyOf is valid if at least one of the subschemas is valid.

Problem here is we render this as a checkboxes group. Meaning we can select none of the entries.

It causes some issues when:

  1. Creating an API with MQTT configured with no security
  2. Try to add a endpoint → the inheritance of shared configuration is not working well because it selects the first checkbox

🌈 Resolution

  • use oneOf in the schema-form.json. It will be rendered as a radio group, and so exactly one value will be selected
  • add a NONE security entry, to be able to use MQTT 5.x without any security
@exalate-issue-sync
Copy link
Author

This issue has been fixed in versions 4.0.9, 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants