DB upgrade fails on JDBC repositories 3.20.x to 4.x

[exalate-issue-sync]

Describe the bug :

When upgrading from 3.20.x to 4.x Gravitee on JDBC repository the upgrade fails due to errors in liquibase scripts. This is probably on all JDBC types, tested on Postgres and MSSQL.

To Reproduce :

Steps to reproduce the behaviour:

1. Create 3.20.x Environment
2. Create some dummy data
3. Upgrade the environment to 4.x
4. See errors in logs

Expected behaviour :

The liquibase should upgrade the db to complete the upgrade.

Current behaviour :

We get errors on liquibase execution resulting in failure on upgrade.

Useful information :

Error logs:

05:39:38.458 [graviteeio-node] [] ERROR i.g.p.c.i.PluginContextFactoryImpl - Unable to refresh plugin context org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'jdbcManagementRepositoryConfiguration': Failed to set up database at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:605) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:520) at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:326) at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234) at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:324) at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:200) at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:973) at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:942) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:608) at io.gravitee.plugin.core.internal.PluginContextFactoryImpl.create(PluginContextFactoryImpl.java:58) at io.gravitee.plugin.repository.internal.RepositoryPluginHandler.loadRepository(RepositoryPluginHandler.java:142) at io.gravitee.plugin.repository.internal.RepositoryPluginHandler.handle(RepositoryPluginHandler.java:114) at io.gravitee.plugin.core.api.AbstractPluginHandler.handle(AbstractPluginHandler.java:59) at io.gravitee.plugin.core.internal.PluginEventListener.lambda$deployPlugin$8(PluginEventListener.java:124) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source) at java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source) at java.base/java.util.Iterator.forEachRemaining(Unknown Source) at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source) at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source) at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source) at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source) at io.gravitee.plugin.core.internal.PluginEventListener.deployPlugin(PluginEventListener.java:122) at io.gravitee.plugin.core.internal.PluginEventListener.lambda$deployPlugins$5(PluginEventListener.java:105) at java.base/java.util.ArrayList.forEach(Unknown Source) at io.gravitee.plugin.core.internal.PluginEventListener.deployPlugins(PluginEventListener.java:105) at io.gravitee.plugin.core.internal.PluginEventListener.onEvent(PluginEventListener.java:63) at io.gravitee.common.event.impl.EventManagerImpl.publishEvent(EventManagerImpl.java:43) at io.gravitee.common.event.impl.EventManagerImpl.publishEvent(EventManagerImpl.java:35) at io.gravitee.plugin.core.internal.PluginRegistryImpl.init(PluginRegistryImpl.java:137) at io.gravitee.plugin.core.internal.PluginRegistryImpl.doStart(PluginRegistryImpl.java:100) at io.gravitee.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:32) at io.gravitee.node.container.AbstractNode.startComponents(AbstractNode.java:180) at io.gravitee.node.container.AbstractNode.doStart(AbstractNode.java:77) at io.gravitee.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:32) at io.gravitee.node.container.AbstractContainer.doStart(AbstractContainer.java:85) at io.gravitee.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:32) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.base/java.lang.reflect.Method.invoke(Unknown Source) at io.gravitee.gateway.standalone.boostrap.Bootstrap.start(Bootstrap.java:155) at io.gravitee.gateway.standalone.boostrap.Bootstrap.main(Bootstrap.java:164) Caused by: io.gravitee.repository.jdbc.exception.DatabaseInitializationException: Failed to set up database at io.gravitee.repository.jdbc.common.AbstractJdbcRepositoryConfiguration.runLiquibase(AbstractJdbcRepositoryConfiguration.java:215) at io.gravitee.repository.jdbc.common.AbstractJdbcRepositoryConfiguration.graviteeDataSource(AbstractJdbcRepositoryConfiguration.java:159) at io.gravitee.repository.jdbc.common.AbstractJdbcRepositoryConfiguration.setApplicationContext(AbstractJdbcRepositoryConfiguration.java:125) at org.springframework.context.support.ApplicationContextAwareProcessor.invokeAwareInterfaces(ApplicationContextAwareProcessor.java:112) at org.springframework.context.support.ApplicationContextAwareProcessor.postProcessBeforeInitialization(ApplicationContextAwareProcessor.java:87) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInitialization(AbstractAutowireCapableBeanFactory.java:419) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1762) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:598) ... 44 common frames omitted Caused by: liquibase.exception.CommandExecutionException: liquibase.exception.ValidationFailedException: Validation Failed:  1 changesets check sum  liquibase/changelogs/v3_20_0/schema.yml::3.20.0::GraviteeSource Team was: 8:0563c8d8d8ba3aff2ebad03472748e26 but is now: 8:1fd1824d8b617e32744ff31e7c3f3eba at liquibase.command.CommandScope.execute(CommandScope.java:235) at liquibase.Liquibase.lambda$update$0(Liquibase.java:237) at liquibase.Scope.lambda$child$0(Scope.java:194) at liquibase.Scope.child(Scope.java:203) at liquibase.Scope.child(Scope.java:193) at liquibase.Scope.child(Scope.java:172) at liquibase.Liquibase.runInScope(Liquibase.java:1618) at liquibase.Liquibase.update(Liquibase.java:229) at liquibase.Liquibase.update(Liquibase.java:213) at liquibase.Liquibase.update(Liquibase.java:198) at io.gravitee.repository.jdbc.common.AbstractJdbcRepositoryConfiguration.runLiquibase(AbstractJdbcRepositoryConfiguration.java:213) ... 51 common frames omitted Caused by: liquibase.exception.ValidationFailedException: Validation Failed:  1 changesets check sum  liquibase/changelogs/v3_20_0/schema.yml::3.20.0::GraviteeSource Team was: 8:0563c8d8d8ba3aff2ebad03472748e26 but is now: 8:1fd1824d8b617e32744ff31e7c3f3eba at liquibase.changelog.DatabaseChangeLog.validate(DatabaseChangeLog.java:354) at liquibase.command.core.helpers.DatabaseChangelogCommandStep.run(DatabaseChangelogCommandStep.java:80) at liquibase.command.CommandScope.execute(CommandScope.java:212) ... 61 common frames omitted

Desktop :

• Environment: [3.20.x > 4.x]