Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match POI label colour to background or icon colour? #1355

Open
matthijsmelissen opened this issue Mar 4, 2015 · 21 comments
Open

Match POI label colour to background or icon colour? #1355

matthijsmelissen opened this issue Mar 4, 2015 · 21 comments

Comments

@matthijsmelissen
Copy link
Collaborator

For some POI, it both makes sense to match the label colour to the background, and to match it to the icon.

Examples of such POI where this is currently an issue are camp site and playground. If we decide to render areas of hospitals etc., the same issue will arise for such POI.

What would be preferred? Here are a couple of examples for camp site. The first is the current rendering.

screenshot from 2015-03-04 14 06 04

screenshot from 2015-03-04 14 06 42

screenshot from 2015-03-04 14 03 30

screenshot from 2015-03-04 14 02 06

@nebulon42
Copy link
Contributor

For me different colours for icon and text always looked strange and my first thought was that of a mistake.

I think POIs should have a distinct colour so the last option has too low contrast for me. I'm not sure if changing the font size according to area size while the icon does not change has the desired effect, but I like the font more. But that's more a general dislike of the appearance of DejaVu Sans with a certain letter spacing.

Briefly: I like the first version best.

@mboeringa
Copy link

I personally find it most intuitive if the color of the icon and accompanying label match, like in examples 1, 3 and 4, as there can be little doubt the icon and label belong to each other, even with more labels and icons in the same location. Matching the color with background color, like in 4, may also be an option, however, you have to consider if you prefer icons with a similar function to have similar color, which may preclude matching with background, or give precedence to the background matching. So function versus consistency with background.

@matthijsmelissen
Copy link
Collaborator Author

Good points above.

Another aspect is that if we keep the text color different from the icon color, the relation between the icon and the area is not clear. For example, in the first picture, it is not clear that the camp sites cover the entire green area - it might as well be a small camp site within a large grass field. In the last picture, it's much clearer that the camp site covers the whole area.

@sommerluk
Copy link
Collaborator

In the last picture, it's much clearer that the camp site covers the whole area.

+1

@matkoniecz
Copy link
Contributor

In the last picture, it's much clearer that the camp site covers the whole area.

What may be misleading. Camp site may cover only part of meadow. Also, what about camp sites in different places where background will be different?

@matthijsmelissen
Copy link
Collaborator Author

What may be misleading. Camp site may cover only part of meadow. Also, what about camp sites in different places where background will be different?

Camp sites are always rendered green (with a darker green outline). There is no meadow or grassland in the picture above, the green comes from the camp site tag.

If the camp site only covers part of a meadow, and it's tagged as an area, then the outline of the camping is still visible. If it's tagged as a point, using the blue icon might be better.

@pnorman
Copy link
Collaborator

pnorman commented Mar 12, 2015

I don't like 2, it looks odd. 4 might look better with more contrast, but I find it hard to look past that.

@matthijsmelissen
Copy link
Collaborator Author

Version with increased contrast:

screenshot from 2015-03-12 19 20 00

Or even more (I think too much):
screenshot from 2015-03-12 19 22 39

@mboeringa
Copy link

I like the last version. Clear and sharp with the dark color, yet still recognizable green.

@matkoniecz
Copy link
Contributor

Camp sites are always rendered green (with a darker green outline). There is no meadow or grassland in the picture above, the green comes from the camp site tag.

In that case greenish icon is a good idea. The only problem is that it removes unification of colour for various accommodations (hotels, hostels, motels etc).

I also like the last version.

@matthijsmelissen
Copy link
Collaborator Author

The only problem is that it removes unification of colour for various accommodations (hotels, hostels, motels etc).

I agree.

Another problem is that it's not clear how the label should be rendered on zoomlevels where the area is smaller. It probably doesn't look good if the label is larger than the area.

@matthijsmelissen
Copy link
Collaborator Author

@imagico @RAytoun Do you have an opinion on this issue? How is this usually handled?

@imagico
Copy link
Collaborator

imagico commented Mar 14, 2015

I don't really have a strong opinion here - a few thoughts though:

  • This seems to be a matter of scale, at low zooms something like a campground is more a POI to be symbolized with icon and corresponding label - even if it is also rendered as an areas while at high zooms it is primarily a landuse, to be symbolized by an area color/pattern.
  • Labeling in the same style as area labels with an icon and aligned to the icon seems wrong. It also would add another variant to the already extremely confusing variety of point label styles demonstrated in Match label colors to icons #1354

@matthijsmelissen
Copy link
Collaborator Author

@pnorman What is your opinion on the darker version?

@pnorman
Copy link
Collaborator

pnorman commented Apr 7, 2015

"Version with increased contrast" looks okay to me. I wouldn't go any lighter.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Apr 7, 2015

Contrast version is better, but I don't get the whole issue. Blue is for all the "sleeping" amenities, why we want (misleading) green instead - just because it can usually be used on grass?

I also don't understand the hospital case - we already display kind-of-reddish icon+label on the yellowish area.

@pnorman
Copy link
Collaborator

pnorman commented Apr 8, 2015

Blue is for all the "sleeping" amenities, why we want (misleading) green instead - just because it can usually be used on grass?

There is no grass in the above images.

camping is both a sleeping amenity and a park amenity, which is a conflict between how we would colour it.

@Circeus
Copy link

Circeus commented Sep 28, 2016

I also don't understand the hospital case - we already display kind-of-reddish icon+label on the yellowish area.

What they mean is that all scaling names currently have text color based on the matching area, and when the colors would differs, as they do here or with hospitals, a decision would have to be made in one direction or the other.

I'm all for scaling the names of such areas (It's been a personal peeve I've had with how hospital campuses look). I also agree that name and icon should be the same color, though I am somewhat of two minds as to whether the original color should be maintained or one that matches the background be used. I'm inching toward green text (I prefer the mid-dark to the darkest option, though) because

  • in this particular case the blue and green clash strongly and unnecessarily against each other.
  • the blue is not that strongly associated with sleeping amenities. I mean in the very example being used we have the same blue applied to a gas station and to public transportation...

@Tomasz-W
Copy link

Tomasz-W commented Jul 2, 2018

@matthijsmelissen @pnorman @kocio-pl @Circeus
Is it still an issue after #1354 merge? There hasn't been any new comments for almost 2 years. What about closing it?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 2, 2018

If there's anything left, please reopen it.

@matthijsmelissen
Copy link
Collaborator Author

matthijsmelissen commented Jan 11, 2019

If there's anything left, please reopen it.

Yes, we still haven't answered the initial question, namely which of the presented renderings is preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants