Leisure POI category #2827
Merged
Leisure POI category #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2017
|
Update with a bigger water park icon: Before |
matthijsmelissen
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2824.
This is a bit more complex PR, because it's not only about making another POI color group sharing the same variable name, but it's also icon/label unification, fixing part of the problem described in #1355, #1794 and #2268 (comment).
While amenity brown is overused, leisure-green (dark leisure-related color) is underused currently. It's used for many labels and only for some icons - namely both golf-related ones. I have changed the color of playground, water park and dog park icons to match their label color (leisure-green). I have not tried to match zoom levels for labels and icons nor was I touching other aspects of text.
Here's the result:
Before
After
Before
After
Before
After