Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering natural=spring on area #1482

Closed
polarbearing opened this issue Apr 14, 2015 · 15 comments
Closed

Add rendering natural=spring on area #1482

polarbearing opened this issue Apr 14, 2015 · 15 comments

Comments

@polarbearing
Copy link
Contributor

Currently springs are only rendered with an icon+name, even when they are mapped as an area.
Small example: http://www.openstreetmap.org/way/206317365
however springs of larger rivers often seep through the sand on a larger area, so this tagging is valid.

It would probably be simple to fill the area with water colour, however it might need to be considered when changing the icon in #1384.

Alternatively, the spring area could be filled with a pattern of spring icons, similar to wetland.

Stats: Node: 58K, area+relation: 690

@polarbearing polarbearing changed the title render natural=spring on area Add rendering natural=spring on area Apr 14, 2015
@matkoniecz
Copy link
Contributor

however springs of larger rivers often seep through the sand on a larger area

I would consider such area as wetland, and I would tag it this way - what would result in expected rendering (though it would require two areas, one for natural=spring, one for natural=wetland).

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 3, 2015

Is this issue to be closed, as you have suggested, or maybe it's something to be considered in #325?

@Tomasz-W
Copy link

@kocio-pl this should be closed for the reasons above.

@polarbearing
Copy link
Contributor Author

Why is this being closed so suddenly?
I don't see reasons above. I see one argument from @matkoniecz regarding one type of spacial spring, in wetland. There are other types of springs, such as the water coming up from the ground, already forming a body of water. You would not consider that as 'wetland'.

@kocio-pl
Copy link
Collaborator

Sorry, for me it's a problem about old discussions without reaching conclusions. There may be many valid arguments, but in the end it's decision what to do. Moreover it's hard for me to imagine such area - could you give an example?

@Tomasz-W
Copy link

As I know, we map water areas as natural=water (or natural=wetland). 'Natural=spring' tag should be added to the first node of a river/ stream way, not water area.
I've checked some cases in Overpass turbo, and most of them it's just bad tagging.

@polarbearing
Copy link
Contributor Author

Can you give examples and say why you consider the tagging wrong?

Springs can be quite large, have a look at https://en.wikipedia.org/wiki/Big_Spring_%28Missouri%29 for one that can spit out up to 57 cubical meters per second! Why does it not deserve an area?

Whether natural=spring on an area should imply being a body of water, or needs an extra outline around, is subject to further discussion.

@kocio-pl
Copy link
Collaborator

This example sounds convincing for me. Since there's also a discussion, I reopen this ticket.

If we should render such area, how should we do it? Just like a node spring or maybe different?

@kocio-pl kocio-pl reopened this Feb 28, 2018
@Tomasz-W
Copy link

Actually, it can be tagged in two ways - the one which I described above, and also as natural=spring area (anyway first node of stream/ river should be connected with spring node/ area)
If we are going to render it, I think it should be just blue water area with spring icon in the middle.

@imagico
Copy link
Collaborator

imagico commented Feb 28, 2018

For the thousandth time: This is not the place to discuss tagging.

If a spring can be mapped as a polygon is not the issue here. The issue here is if polygons tagged natural=spring should be rendered differently compared to a node with this tag. This likely makes no sense because however you define the outline of a spring (which is hard to do in a verifiable way) this will either qualify as natural=water or natural=wetland or be part of a larger area that qualifies as such.

@polarbearing
Copy link
Contributor Author

For the thousandth time: This is not the place to discuss tagging.

Right, but as tagging and rendering are related, it is necessary to point out which things are well defined, and which need further discussion.

@polarbearing
Copy link
Contributor Author

Example of spring tagged on area, after recent refurbishment:
spring-on-area

Due to #3253, the icon would be invisible if the spring area were mapped as a natural=water body.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 9, 2019

#3253 was fixed by #3738, so spring icons now render above water areas without problems.

I agree with the comments above #1482 (comment) - a spring can be mapped as an area of water or a wetland.

Closed.

@jeisenbe jeisenbe closed this as completed Sep 9, 2019
@b-unicycling
Copy link

I don't agree with the solution of tagging them as water, because they lose their property of being a spring that way. People have now tried to solve this by using water=spring, but I thought we were told not to map for the renderer which the solution of tagging them as water bodies absolutely is doing.

@imagico
Copy link
Collaborator

imagico commented Apr 28, 2024

I don't agree with the solution of tagging them as water

I don't think anyone has suggested this here.

The problem that mappers need to apply several primary tags with the same key to the same geometry is a common one and not unique to springs - the common technique is to create two features representing the two different concepts (the spring as well as the water covered area/the area of water saturated ground a.k.a. wetland). This also allows applying secondary tags in a semantically non-ambiguous way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants