Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.45.0 #2467

Closed
kocio-pl opened this issue Nov 27, 2016 · 10 comments
Closed

Release v2.45.0 #2467

kocio-pl opened this issue Nov 27, 2016 · 10 comments
Assignees
Labels

Comments

@kocio-pl
Copy link
Collaborator

I think it's time to release v2.45.0 and I guess it's good to make it in a transparent way, so the new maintainers, including me, could learn the process in practice (basics are described in RELEASES.md). One can see current unreleased changes here:

v2.44.1...master

Which PRs do you think should be merged before the release? I like our current release time frame (every month or so) and would like to keep it.

@pnorman
Copy link
Collaborator

pnorman commented Nov 27, 2016

#2454 is the only PR that stands out as something we might want to push in. A lot of the current PRs are code cleanup, documentation, and other internal changes. These changes are important, but since they're not user-facing it doesn't particularly matter if they get in before or after a release.

@nebulon42
Copy link
Contributor

#2454 not ready yet IMO.

@matthijsmelissen
Copy link
Collaborator

I'd prefer to release 2.45.0 without #2454, I agree it needs some more work.

@kocio-pl
Copy link
Collaborator Author

I also think #2454 is not ready. Merging now would break current review process and this is rather important change, like all the other road rendering changes. I was rather thinking about long overdue PRs and small code changes which need just a final touch.

I have updated latest changes in CHANGELOG.md, please take a look if the wording is clear before release.

@kocio-pl
Copy link
Collaborator Author

Next step - updated preview.png, because construction and pitch color are changed since last rendering. It was done through the GitHub UI, just like the Changelog, which is also now ready for release.

@kocio-pl
Copy link
Collaborator Author

Ok, new release is out and waiting for deployment on OSM servers.

The only thing left is:

If there are any long-running development branches (e.g. lua) check them out and merge the new release with git merge $NEW_RELEASE.

Should I really do that?

@matthijsmelissen
Copy link
Collaborator

I don't think we have been doing that over the past few releases, but maybe we should.

@kocio-pl
Copy link
Collaborator Author

You're right, a difference is quite big now. I don't feel like touching it to not spoil anything, so I leave it to @pnorman probably.

BTW: Why do we require Noto Emoji font? It holds back deployment on OSM servers.

@pnorman
Copy link
Collaborator

pnorman commented Nov 28, 2016

I don't think we have been doing that over the past few releases, but maybe we should.

I have. I can do this release too.

@kocio-pl
Copy link
Collaborator Author

Thanks, I consider this issue to be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants