Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of railway=platform + public_transport=platform + light_rail=yes + area=yes #3242

Closed
jc86035 opened this issue May 21, 2018 · 14 comments

Comments

@jc86035
Copy link

jc86035 commented May 21, 2018

Expected behavior

The platforms, given that they have the four tags, should render

Actual behavior

Platforms don't render at z19 (either a tile caching issue, or an issue with light_rail not being styled, or something about railway=platform)

Links and screenshots illustrating the problem

The platform

@Tomasz-W
Copy link

Duplicate of #435

@jc86035
Copy link
Author

jc86035 commented May 21, 2018

@Tomasz-W this is not the same issue; the issue is that railway=platform stopped rendering, and I don't know why it happened.

@kocio-pl
Copy link
Collaborator

That's because it has covered=yes tag, see #3162.

@kocio-pl kocio-pl added the roads label May 21, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone May 21, 2018
@kocio-pl
Copy link
Collaborator

Compare it also with other covered platform, which has a cover (building) tagged:

https://www.openstreetmap.org/way/220343050

@jc86035
Copy link
Author

jc86035 commented May 22, 2018

Are the platforms tagged incorrectly? They are entirely covered by a canopy but perhaps using shelter=yes instead would be appropriate.

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 22, 2018

Interesting case. This was my design decision to hide covered platforms, because this usually means being under the roof and that makes clutter. Covered roads are treated like tunnels IIRC, so we treat the cover as something solid:

WHERE (tunnel = 'yes' OR tunnel = 'building_passage' OR covered = 'yes')

See also: https://wiki.openstreetmap.org/wiki/Key%3Acovered

@kocio-pl
Copy link
Collaborator

Probably covered=trees would be both accurate and rendering as expected.

@jc86035
Copy link
Author

jc86035 commented May 22, 2018

@kocio-pl Not a tree canopy, a metal one (although there are trees next to it). Should I remove the covered=yes tag from the 140 or so platforms which have the same sort of metal shelter?

@kocio-pl
Copy link
Collaborator

Oh, I see. I guess adding this shelter (looks like building=roof to me) is the right way.

@jc86035
Copy link
Author

jc86035 commented May 22, 2018

Should that tag be on the same way as the platform, or should a new area with the same nodes have that tag?

@kocio-pl
Copy link
Collaborator

I think new area, since it's probably not exactly the same shape.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 1, 2018

Another possibility is to use covered=partialin some cases:

https://taginfo.openstreetmap.org/tags/covered=partial

@jc86035
Copy link
Author

jc86035 commented Jun 1, 2018

Out of interest, is it possible in Mapnik to only render parts of a multipolygon? (For the case where an object is partly under a building, and the bits outside the building are separate ways without covered=yes, but the rest of the tags are on the relation. Platforms with a single ref=* cannot be split into multiple ways/areas, since the label should only be rendered once in the middle of the platform.)

@jc86035
Copy link
Author

jc86035 commented Jun 1, 2018

On second thought, it would be fairly difficult to render the label sensibly if the middle of the platform were invisible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants