Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tourism=apartment, is rendered different if applied to separate element or tagged together with a building #3487

Closed
Ruediger34 opened this issue Nov 1, 2018 · 5 comments

Comments

@Ruediger34
Copy link

Expected behavior

Render tourism=apartment on a node in the same way as on an area.

Actual behavior

If tourism=apartment and name=XXX is set on an area, the name is renderd on zoom=17 without the icon of tourism=apartment. On zoom=18 the icon is renderd correctly.

If tourism=apartment is set as node all work as expected.

Links and screenshots illustrating the problem

First, I will show if the tag is applied to an area.

Zoom=17, shows the name is renderd without the icon:
grafik

Zoom=18 is renderd correctly:
grafik

Second, the tag is applied to a node:
Zoom=17, nothing is visible:
grafik

Zoom=18, the icon is renderd:
grafik

@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 1, 2018

Very similar to #3472

  1. Can you link the affected way?

  2. Is this apartment really covering entire building? I would expect that either it is not filling entire house or it is not an apartment. Entire building for rent sounds like https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dguest_house

  3. Is name applying also to the building or just to a rentable accommodation?

@Ruediger34
Copy link
Author

  1. Tag applied to an area: https://www.openstreetmap.org/way/395066145#map=19/49.06968/13.10727 - tag applied to a node: https://www.openstreetmap.org/node/1826689349

  2. I have also seen multiple tourism=apartments in one building. But in most cases it should be only one tourism=apartment in a house.

  3. These names are not the name of the building. The name applies to the rentable apartment.

@matkoniecz
Copy link
Contributor

These names are not the name of the building. The name applies to the rentable apartment.

In that case problem is caused by violation of https://wiki.openstreetmap.org/wiki/One_feature,_one_OSM_element

https://www.openstreetmap.org/way/395066145#map=19/49.06968/13.10727 mixes apartment and building

While often shops/accomodations/etc are tagged on building outline it is not correct. Tagging of https://www.openstreetmap.org/way/395066145#map=19/49.06968/13.10727 means that name tag applies both to tourism=apartment and building=yes.

@matkoniecz matkoniecz changed the title tourism=apartment, is renderd different if applied to node and area. tourism=apartment, is rendered different if applied to separate element or tagged together with a building Nov 1, 2018
@matkoniecz
Copy link
Contributor

Closing as caused by an an invalid data.

situation 1

name tag applies only to the apartment - then there should be separate objects for apartment and building

situation 2

name tag applies to both building and apartment - then rendering is correct

@matkoniecz
Copy link
Contributor

As this seems to be an OSM data issue I opened https://www.openstreetmap.org/note/1580006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants