addr:unit localization

[andrewharvey]

addr:unit was rendered in https://github.com/gravitystorm/openstreetmap-carto/pull/2494/files

Buildings are labelled "{addr:housenumber} {addr:unit}" in some parts of the world this is very confusing and misleading. Speaking for Australia it's generally going to be
"{addr:unit}/{addr:housenumber}" or "{addr:unit} {addr:housenumber}".

[jeisenbe]

In the USA it’s {addr:housenumber} {addr:street} #{addr:unit} Eg 1456 First Street #4 Or {addr:house number} {addr:street} Unit {addr:unit} Eg 1456 First Street Unit A Or rarely {addr:housenumber} {addr:unit} {addr:street} The last is usually only used if the unit is a letter or faction, eg 1459A Fifth Street Or 1459 1/2 Fifth Street We could try adding a divider like a dash?

[jeisenbe]

Perhaps the problem is also that the housenumber and the unit number are in an identical text style?

[andrewharvey]

Perhaps the problem is also that the housenumber and the unit number are in an identical text style?

I'm not sure you can do much with text styling alone apart from maybe italics for the unit? Though that's still not clear to me. For Australia at least and probably many other places simply formatting as {unit}/{housenumber} would be clear even with the same text style..

[HolgerJeromin]

In Germany there is no uniform standard for units.
But there are some (official full featured) house numbers with includes x/y style (the place got x a few years ago, but there were more buildings built):
https://www.openstreetmap.org/way/285463790#map=19/48.40511/9.95411
But as there is no unit involved here this is probably no show blocker for rendering x/y for units.

[andrewharvey]

Maybe before we go to far, which countries would unit/housenumber be correct and which countries would the current housenumber unit correct? In the short term maybe we can just change the default if one group is significantly larger.

I couldn't see any localisation support in the code base already to support different styles per region. I was tempted to do a join on country admin boundary polygons from every address point/polygon to assign the country code to the address and then allow the style to use a country code lookup, but not sure if that would make it too slow...

[pnorman]

We do not support rendering in different ways depending on region.