Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility poles rendered within tertiary highways at z16 to z18 #3925

Open
jidanni opened this issue Oct 9, 2019 · 14 comments
Open

Utility poles rendered within tertiary highways at z16 to z18 #3925

jidanni opened this issue Oct 9, 2019 · 14 comments
Labels

Comments

@jidanni
Copy link

jidanni commented Oct 9, 2019

Despite one's best efforts in the editor
openstreetmap/iD#6925 (comment)
it is still a fact that most utility poles will end up getting rendered within a road.

Everybody knows that utility poles are on the side of a road, not within it. Don't get me wrong: rendering utility poles is very important. Just please, when rendering a road, render the pole to the nearest edge. Thanks.

Autopilot cars will also thank you, no more fear of slamming in to them.

Don't worry. If they are really in the center of a road, they will be on a traffic island.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 9, 2019

Area discussed in the linked comment: https://www.openstreetmap.org/#map=17/24.19249/120.87513

Node example: https://www.openstreetmap.org/node/4778301333#map=19/24.19948/120.87570
(Is this a very narrow road, with the poles quite close to the edge? This node is only 1 meter from the centerline of the highway=tertiary way. Perhaps the source of the data for the road and the source for the poles are not aligned properly? It will also be easier to understand once the power=minor_line is mapped)

However, many of the properly-aligned poles and roads will show overlap at z16 and z17 in places like Taiwan which are near the equator, since the tertiary road rendering at z16 and z17 is over 20 meters wide (10 pixels is 24 meters at the equator at z16, and 18 pixels is 21.6 meter at z17). Since many tertiary roads are only 6 to 8 meters wide, the rendering is quite a bit wider than the real feature at these zoom levels.

We could improve this a little by narrowing the rendering of tertiary highways at z16 to z19. This would probably require changing the color to yellow, which means that motorways would need a new rendering as well.

when rendering a road, render the pole to the nearest edge.

This isn't very easy to do with this map style and the rendering toolchain we use. It might also confuse mappers if poles close to roads were moved farther out, but those farther away were at the precise location. Such pre-processing of data is more feasible for specialized map styles and custom maps.

@jeisenbe jeisenbe added the power label Oct 9, 2019
@jidanni
Copy link
Author

jidanni commented Oct 9, 2019

Streetview gives you a general idea. Anyway trying to better position these pole will in fact probably just make things worse, as we are not supposed to "edit for the renderer" anyway.

Different sized roads at different latitudes? There should be a formula to keep them the same size no matter what latitude!

Yes, yellow would be better than "red dashes" etc.

@pnorman
Copy link
Collaborator

pnorman commented Oct 9, 2019

This isn't very easy to do with this map style and the rendering toolchain we use. It might also confuse mappers if poles close to roads were moved farther out, but those farther away were at the precise location. Such pre-processing of data is more feasible for specialized map styles and custom maps.

It's both not possible, and not something we want to do. It's not practical to reposition poles or other POIs away from roads given the constraints of processing that can be done in a reasonable amount of SQL. It's not something we want to do because we want to avoid preprocessing or altering geometries as one of the style goals because it's used for mapper feedback.

@pnorman pnorman closed this as completed Oct 9, 2019
@jidanni
Copy link
Author

jidanni commented Oct 9, 2019

because it's used for mapper feedback.

OK, I will from now on place roadside poles 12 meters away from centerlines of two meter wide roads despite
https://wiki.openstreetmap.org/wiki/Good_practice#Don.27t_map_for_the_renderer .

@kennykb
Copy link

kennykb commented Oct 9, 2019 via email

@jeisenbe
Copy link
Collaborator

While @pnorman is correct that we can't completely fix this issue, we could keep it open until we render tertiary roads more narrowly. If tertiary roads were 30% narrower, many of the poles in the example images would not overlap with the road rendering at z17 and z18.

@kennykb suggests adjusting by width= tags - this was considered too complex back with #1853 for aeroway=runway

@kocio-pl
Copy link
Collaborator

So this is related to #3540 - it would help to avoid artificial fusing one-way tertiary lines.

@jidanni
Copy link
Author

jidanni commented Oct 11, 2019

Well all I know is mom and pop editors hurriedly pick "minor road" etc. thus would never think of width=. Plus twisty country roads don't have much of a constant width in poorer countries. Also in the editor one is simply focused on "put the pole next to the road", which he does, and expects it to stay that way...

@jeisenbe jeisenbe changed the title Utility poles end up within roads Utility poles rendered within tertiary highways at z16 to z18 Oct 11, 2019
@jeisenbe
Copy link
Collaborator

I've edited the title to "Utility poles rendered within tertiary highways at z16 to z18" and reopened the issue, since we can partially solve this by a narrower rendering of highway=tertiary

@jeisenbe jeisenbe reopened this Oct 11, 2019
@newtestaccount4949
Copy link

tertiary roads are often already quite difficult to distinguish from residential roads at z16 to z18, so narrowing isn't the best idea

@jeisenbe
Copy link
Collaborator

Right, we can only narrow highway=tertiary significantly if we also change the color. See #3540 for an option.

@goldfndr
Copy link

goldfndr commented Feb 7, 2020

Would it be workable to use secondary's color and unclassified's width for tertiary? (and perhaps narrower tertiary_link roads)

@jeisenbe
Copy link
Collaborator

@goldfndr - see #3540 for that idea

@goldfndr
Copy link

The closest comment I can see to this idea is your comment, but I apparently misinterpreted your "switch the color spectrum" language as "increase the color spectrum", like I did for your comment above. My apologies.

(I did note that construction=secondary uses the secondary color at a narrower width, but it also uses a dasharray, so it's easily distinguished.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants