Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline of landuse=quarry and highway=pedestrian areas look like barriers #3976

Open
jeisenbe opened this issue Nov 19, 2019 · 5 comments
Open

Comments

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 19, 2019

Expected behavior

  • Outlines of landcover area features should be subtle, just visible enough to show when two similar areas meet
  • The casing of highway areas should be clear enough to define the area and closely match the linear highway rendering, BUT
  • Outlines and casings of areas should not look like barriers such as fences or walls

Actual behavior

  • The dark outline of landuse=quarry areas looks too similar to a fence or wall, as mentioned in Confusing amenity=parking_space rendering  #3974 (comment)
  • The quarry outline starts at a lower zoom level than most area outlines.
  • Also highway=pedestrian areas have a strong outline which can be confused with barriers

Test images illustrating the problem

z19 gardens and fountain next to a pedestrian area - but it looks like they are surrounded by fences or walls
z19-kennedy-gardens-fountain-before

z17 quarry by quarry (test)
z17-quarry-by-quarry

@Adamant36
Copy link
Contributor

Adamant36 commented Nov 20, 2019

Well I agree that both of these things are issues, less so with highway=pedestrian though, they would be better as two separate issues IMO, but I still appreciate you opening this. My personal opinion on quarry borders is that they should be removed. I'm not to sure on highway=pedestrian.

@Prince-Kassad
Copy link

highway=pedestrian areas are synced with highway=pedestrian ways which have the same heavy border at the edges. Can't change one without changing the other.

@nickvet419
Copy link

nickvet419 commented Feb 10, 2020

I looks like that because fences and walls should be rendered differently than a thin single line to differentiate themselves differently than an area boarder. This issue is also related to the derendering of barrier=kerb and others #3969 #3714 #3975

@jeisenbe
Copy link
Collaborator Author

I believe we can fix this for quarries by changing the quarry outline color from gray to darken(@quarry, 10%):

z16 Slate quarries in Wales - current
https://www.openstreetmap.org/#map=16/53.1243/-4.1475.png

  • Note that there is a wall or fence which comes right up to the border between the quarries, but stops there. It appears to be the same color as the quarry outline right now. There are some parts of the quarry outline that also have a wall or fence in that position.

slate-quarries-before-16:53 1243:-4 1475

z16 after - 10% darkened @quarry color outline

  • Now the quarry outline is clearly lighter than the barrier

slate-quarries-after-z16-10percent

z18 current
z18-slate-quarries-current

z18 after
slate-quarries-after-z18-10percent

This should also make it easier to adapt the style or change the quarry color in the future (though it is always a good idea to adjust the darken percentage if the fill color is lighter or darker than before)

I also tested darken(@quarry, 15%) and darken(@quarry, 20%) but these look too similar to the linear barrier rendering.

@kocio-pl
Copy link
Collaborator

That sounds resonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants