Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change quarry outline to 10% darkened quarry color #4063

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

jeisenbe
Copy link
Collaborator

@jeisenbe jeisenbe commented Mar 8, 2020

Fixes part of #3976

Changes proposed in this pull request:

  • Change quarry outline to 10% darkened quarry color rather than gray
  • This makes the outline significantly lighter, and clearly different than a barrier

Currently the quarry outline looks similar to a fence or wall on untagged land. This makes it hard to tell if a quarry is surrounded by a wall or fence, or not.

I also tested darken(@quarry, 15%) and darken(@quarry, 20%) but these look too similar to the linear barrier rendering, while the current commit uses darken(@quarry, 10%) and this works well.

This should also make it easier to adapt the style or change the quarry color in the future (though it is always a good idea to adjust the darken percentage if the fill color is lighter or darker than before)

Test rendering with links to the example places:

z16 Slate quarries in Wales - current
https://www.openstreetmap.org/#map=16/53.1243/-4.1475.png

  • Note that there is a wall or fence which comes right up to the border between the quarries, but stops there. It appears to be the same color as the quarry outline right now. There are some parts of the quarry outline that also have a wall or fence in that position.

slate-quarries-before-16:53 1243:-4 1475

z16 after - 10% darkened @quarry color outline

  • Now the quarry outline is clearly lighter than the barrier

slate-quarries-after-z16-10percent

z18 current
z18-slate-quarries-current

z18 after
slate-quarries-after-z18-10percent

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. The outline is barely visible in a lot of cases with this change but that is not really a problem. Will likely be subject to review for solving #2905.

@jeisenbe jeisenbe merged commit 908c740 into gravitystorm:master Mar 21, 2020
@jeisenbe jeisenbe deleted the quarry-outline branch March 21, 2020 12:28
jeisenbe added a commit to jeisenbe/openstreetmap-carto that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants