Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.0.0 #4046

Closed
jeisenbe opened this issue Mar 2, 2020 · 16 comments
Closed

Release v5.0.0 #4046

jeisenbe opened this issue Mar 2, 2020 · 16 comments
Labels

Comments

@jeisenbe
Copy link
Collaborator

jeisenbe commented Mar 2, 2020

Now that the schema_changes branch has been merged to master, the next release will be a major version which will require a database reload for style users.

It has been suggested that we should also make a couple more changes prior to this release:

  1. Move all .mss files to a new subdirectory - issue Move MSS files to their own directory #4041
  1. Change required Mapnik and Carto versions - Unpaved rendering #3399 (comment)
  • Raise to Mapnik 3.0.22 and Carto 1.2.0 to allow new features like global pattern alignment, handling surfaces properly
  • Can wait a few months - see Release v5.0.0 #4046 (comment)
  1. Merge way_area conditions for all ST_PointOnSurface layers #4042 - though changes are requested at the moment

Are there any other things that need to happen before v5.0.0 is released? It would be nice to do it this week or next.

(I'm aware that I will need to rebase my open PRs afterward, and that's fine.)

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Mar 2, 2020

  1. Merge way_area conditions for all ST_PointOnSurface layers #4042 - though changes are requested at the moment - done

@pnorman
Copy link
Collaborator

pnorman commented Mar 2, 2020

  • @pnorman - are you planning to do this?

Yes.

I want to sort out #4042 before 5.0.0 as well.

I'm against requiring a Mapnik that's not in Ubuntu LTS, particularly when we don't have features that need it yet.

@sommerluk
Copy link
Collaborator

On the other hand the new Mapnik will be in Ubuntu 20.04 LTS which will (as far as announced) be out in only seven weeks… Might be worth to wait?

@pnorman
Copy link
Collaborator

pnorman commented Mar 3, 2020

On the other hand the new Mapnik will be in Ubuntu 20.04 LTS which will (as far as announced) be out in only seven weeks… Might be worth to wait?

We can release a new major version when 20.04 is out and people have had time to move to it.

@sommerluk
Copy link
Collaborator

Okay. What would be a reasonable time frame for that?

@pnorman
Copy link
Collaborator

pnorman commented Mar 4, 2020

Okay. What would be a reasonable time frame for that?

I'm not sure - probably a month or two after, depends how many 5.x releases we want to do.


#3719 is something I want to get in to 5.x

@pnorman pnorman self-assigned this Mar 4, 2020
@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Mar 7, 2020

2 last PRs which we need to merge are #4055 and #4056, though I need to fix the lua tests for #4055 still. After that perhaps @pnorman can get the release done for this major version change?

@jeisenbe
Copy link
Collaborator Author

#4055 is closed, replaced by the approved PR #4075, and #4056 is closed, so I believe everything is ready?

@pnorman
Copy link
Collaborator

pnorman commented Mar 15, 2020

I'd like to wait a few days to give any new bugs a chance to shake out. I'll tag it during the week.

@pnorman
Copy link
Collaborator

pnorman commented Mar 17, 2020

Absent anything new, I'll tag 5.0.0 after work

@pnorman
Copy link
Collaborator

pnorman commented Mar 18, 2020

I upgraded to a new dev machine and I have to figure out why I'm not getting anything with the shapefiles loading when I use kosmtik

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Mar 18, 2020

I'm not getting anything with the shapefiles loading when I use kosmtik

Do you mean the oceans and icesheets are not visible?

Did you upgrade to a newer version of Mapnik and Carto?

You might need to delete the shapefile indexes.

See comment: #3399 (comment)

Also see #3717 and #3717 (comment)

But see my experience with deleting the .index files for the shapefiles: #3399 (comment) with this suggested solution #3399 (comment) - which I haven't tried yet.

@pnorman
Copy link
Collaborator

pnorman commented Mar 18, 2020

Did you upgrade to a newer version of Mapnik and Carto?

I did a clean install, but the version of shapeindex my system has is from an older version of Mapnik than Kosmtik uses because node-mapnik is including a binary blob for some unreleased version of Mapnik

You might need to delete the shapefile indexes.

I'll try that after work

@jeisenbe
Copy link
Collaborator Author

Besides re-importing the rendering database, will style users need to take any additional action to update the route=ferry indexes when switching to v5.0.0?

@pnorman
Copy link
Collaborator

pnorman commented Mar 19, 2020

will style users need to take any additional action to update the route=ferry indexes when switching to v5.0.0?

No. All their indexes will be gone, they just need to recreate them like normal

@pnorman
Copy link
Collaborator

pnorman commented Mar 19, 2020

Done.

@pnorman pnorman closed this as completed Mar 19, 2020
@pnorman pnorman removed their assignment Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants