Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label for natural=beach #455

Closed
HolgerJeromin opened this issue Apr 4, 2014 · 1 comment · Fixed by #941
Closed

Add label for natural=beach #455

HolgerJeromin opened this issue Apr 4, 2014 · 1 comment · Fixed by #941

Comments

@HolgerJeromin
Copy link
Contributor

Please render the name-tag for beaches (natural=beach) for nodes and areas. The area names were lost with dropping the catch all. example:
http://www.openstreetmap.org/way/143585400

regression proof :-)
http://bl.ocks.org/tyrasd/raw/6164696/#15.00/51.8159/4.0655

thanks

@finetjul
Copy link

After a quick look (I'm new here), it seems that the following could be added here: https://github.com/gravitystorm/openstreetmap-carto/blob/master/amenity-points.mss#L575

[natural = 'beach']::natural {
    [zoom >= 16] {
      text-name: "[name]";
      text-size: 12;
      text-fill: #000;
      text-face-name: @book-fonts;
      text-halo-radius: 1;
      text-wrap-width: 10;
    }
  }

I did not try though, it was just by looking at the code (and maybe the text and halo color could be other than black/white but more yellow-ish)

finetjul added a commit to finetjul/openstreetmap-carto that referenced this issue Apr 18, 2014
text-fill could have also been #000

Closes gravitystorm#455
@matthijsmelissen matthijsmelissen changed the title please (re)add beach names (Re)add beach names Sep 24, 2014
@matthijsmelissen matthijsmelissen changed the title (Re)add beach names Add label for natural=beach Sep 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants