Render both housenumber and housename

[sommerluk]

Render both housenumber and housename if both are present. Same colour for all address-related features. A little bit of documentation.

Fixes #2328
Fixes #735

[nebulon42]

I think that darkening the line colour of address interpolation requires previews.
Why not merge the whole housenumber, housename business into one layer?

[sommerluk]

On the left : before – On the right: after

http://www.openstreetmap.org/#map=18/41.86157/12.56747

[sommerluk]

Why not merge the whole housenumber, housename business into one layer?

Currently housename has line wrap, but housenumber doesn’t. This seems okay for me. I think unifying it – if desired – should be separate PR.

[polarbearing]

Can somebody guide me into what difference I am supposed to see in that left/right comparison?

[sommerluk]

@nebulon42 had requested at #2351 (comment) a preview:

I think that darkening the line colour of address interpolation requires previews.

Indeed the line colour has slightly changed – though the change is almost invisible.

[nebulon42]

Thanks, as you said this seems to be neglectable.

[pnorman]

addr:housename is very seldom found in North America, so I don't feel able to review this.

[nebulon42]

Looks quite good to me. Only on z17 the house names might be hard to read because they might overlap with other things. Since this is not different from the house name only rendering I'm not going to suggest it to be changed in this PR.

However, I really think that as follow-up we should

• give the house numbers and names a faint halo
• unify house name and house number layers

[nebulon42]

Some screenshots:

z17

house names only (current rendering)

z18

[sommerluk]

New commit: Unify address layers and use halo.

Screenshot (aritificial example data):

[matthijsmelissen]

Wouldn't this add a spurious \n for nodes with house name and without house number?

[nebulon42]

No, as this line matches only if addr_housenumber is not null. So addr_housenumber and addr_housename must be different from null.

[aceman444]

See #2328. What is the purpose of rendering addr:housename on 10 shops inside a building that itself has that name?

[sommerluk]

@aceman444 We do not render addr:housename (nor addr:housenumber) for shops. We render it only for buildings.

[aceman444]

OK, that's better. But on a building, the same value would be in 'name' so what is the benefit of rendering addr:housename ?

[sommerluk]

But on a building, the same value would be in 'name'
No. Only 44% of the 280 000 elements with “addr:housename” have also “name”.

so what is the benefit of rendering addr:housename ?
Getting rendered the “addr:housename” on buildings when there is no “name” tag.

As stated in the source code documentation:

Building names (rendered differently from addresses because they are no official postal addresses)

On a building, “name” is not related to postal addresses, but “addr:housename” is. If both are present, “name” has higher priority.

[aceman444]

'addr:housename' on a building without 'name' makes no sense to me. But it is true the addr: wiki page is ambiguous about when to use addr:housename.

But rendering it may encourage tagging addr:housename instead of name (which I have already seen in the wild).