New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rendering for shop=coffee #2386
Conversation
shop=coffee is now at 2070 uses. |
@kocio-pl Could you rebase this? |
Done. |
The icon is ok. But I'm against merging this until the shop discussion has progressed further. |
Depends on #2444 then. |
There's no progress in the shop discussion, so I'm not sure what to do - I'm ready to rebase it, but it's tedious for me as a casual git user, so it makes sense only if merging probability is high. |
I think we need to give the shop discussion some more time. |
I would say let's merge that one in since it is already proposed. It makes a round 50 of shop icons. But I would be reluctant to accept new proposals. |
Yes, good idea. |
Done. I hope that SVG code is proper. |
Is there any problem left to solve here? |
Sorry for the long delay. I would merge it right away, but I saw that you are using a transform to rotate the bean. If you could clean this up (remove the transform) this would be great. If this is too much work I would also merge it as is. |
I have used file from @Jotam and I don't know how to fix this problem. If you or him (or anybody else) could fix the icon, I would simply update the code. |
Turned out to be quite easy. Can you check for the last time? Then I will merge this. |
Ready. I've checked and it works as expected. I made it to be just one commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendering test ok.
Resolves #2227.
The number of uses is currently 1986, so very close to a safe 2k limit.