Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rendering for landuse=farm #2554

Merged
merged 1 commit into from Mar 21, 2017

Conversation

nebulon42
Copy link
Contributor

This removes rendering for landuse=farm, currently rendered like landuse=farmland.

landuse=farm is discouraged since 2013 and deprecated since 2014. There is a prominent warning on the wiki page and also the JOSM validator issues warnings about it.

Taghistory shows a steady decline, but according to Taginfo there are still around 360 000 uses.

Removing it from the rendered tags shall speed up the re-tagging into either farmland or farmyard, but since there are still quite some uses there will be changes to the map. However, this is intended.

@kocio-pl
Copy link
Collaborator

Sounds good to me. I think we should write about this plan on the Talk and Tagging list (and possibly on some other popular places, like forum).

@nebulon42
Copy link
Contributor Author

nebulon42 commented Jan 19, 2017

Sure, I can do that. I will wait a bit so that others have a chance to see this PR first.

@pnorman
Copy link
Collaborator

pnorman commented Jan 25, 2017

iffy about this, since landuse=farm has a well-defined meaning and is commonly used.

@nebulon42
Copy link
Contributor Author

I guess it does, but I have cleaned up quite some usages in Austria lately and they were ambiguous. Some meant landuse=farmyard and some others meant landuse=farmland.

@aceman444
Copy link

It may have a meaning (farmland), but the problem seems to be people do not know the true meaning and use it for something else (farmyard). Even if you clean up all uses of it in a region, people may still introduce the tag again on some objects and with the wrong meaning.

Also notice JOSM does not support the tag anymore.

@imagico
Copy link
Collaborator

imagico commented Jan 26, 2017

In general I think this is a good idea. We should of course be careful in implementing changes in tag use just because some voiceful group of active mappers decided about them. But here we can clearly see this change is widely accepted and there is a clearly identified problem with the old tagging.

However we probably should pre-announce this intention some time in advance so there is some room to organize a concerted effort in mapping (along the lines of everyone should have a look at those areas in his/her local mapping environment and verify + fix farmland/farmyard mapping). There have also been some imports in the past with landuse=farm, for example the French CLC import if i am not mistaken - local communities might want to have the chance to contemplate these things in advance of such a change.

Note although use of the tag is in steady decline over the past 1-2 years there are still mappers actively using the tag - might be a good idea to determine the reasons.

@aceman444
Copy link

Yes, CLC was one of the "culprits" using 'farm'. However, it used it in the correct way as farmland, it probably couldn't distinguish small-area features as a farmyard.

We have cleaned the whole of our European country from landuse=farm.

@matthijsmelissen matthijsmelissen merged commit 91eddb1 into gravitystorm:master Mar 21, 2017
@matthijsmelissen
Copy link
Collaborator

Thanks! Could any of you, perhaps @imagico, communicate this with the community?

@nebulon42
Copy link
Contributor Author

I can do that.

@nebulon42
Copy link
Contributor Author

nebulon42 commented Mar 22, 2017

Links to notifications:
https://forum.openstreetmap.org/viewtopic.php?pid=637717 (Forum overall)
https://forum.openstreetmap.org/viewtopic.php?pid=637719 (Form Germany)
https://lists.openstreetmap.org/pipermail/talk/2017-March/077741.html (Talk/tagging mailinglist)
https://lists.openstreetmap.org/pipermail/talk-de/2017-March/113904.html (Talk-de/Talk-at)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants