Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High-contrast fonts as alternative fonts #2725

Closed
wants to merge 1 commit into from

Conversation

sommerluk
Copy link
Collaborator

Resolves #2692

Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel that overall this change makes the cartography worse.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 3, 2017

That's why I'd like to hear someone using non-latin scripts to comment. It could make western world look worse, but help some other parts of the world look better, which would be good for universal map diversity. So I want to know if/how it really works for the rest of the world.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 4, 2017

I'd like to know what the people who commented #2496 think about this change. @saeedghazijoolaee, @jojo4u, @lyxys, @BoFFire, what's your opinion?

@sommerluk
Copy link
Collaborator Author

As #2496 was about the arabic script, it might be worth to say that this PR does not change the rendering of the arabic script.

(Our current arabic font, “Noto Naskh Arabic”, is indeed a high-contrast font yet. As there are no alternatives, we use it for both, @regular and @oblique. In the upcoming Noto Phase III, there will be additionally an Arabic Sans in many weights and widths which will have low contrast. So after the release of Noto Phase III, we could treat the currently used Naskh font as @oblique and in contrast use the new Arabic Sans as @regular…)

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 4, 2017

Sorry for misunderstanding. This font topic is beyond my expertise (and pretty complicated, since I've read it few times and still don't follow), but it's not about me - I'd like to know what real people using different scripts are thinking.

So, what language/country communities could be a target we should ask? We can probably contact with the most active/biggest ones on the forum and generally on the Talk list.

@sommerluk
Copy link
Collaborator Author

Language communities following Wikipedia:

  • For CJK script: chinese (in all its dialects), japanese and korean.
  • For Devanagari script: Hindi, Marathi, Konkani, Nepali, Sanskrit
  • For Bengali script: Sanskrit, Bengali, Assamese, Kokborok, Bishnupriya Manipuri, Khasi, Meitei Manipuri, Hajong and Sylheti
  • For Malayalam script: Malayalam

I think anyway this is not a complet change of font. We stay within the same font superfamily and change only the font face (for a limited scope of labels).

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 8, 2017

Thanks! Could you also put some before/after renderings for all these scripts, so people see what is changing?

@sommerluk
Copy link
Collaborator Author

Left before. Right after.

Latin script:
screenshot 1

CJK script:
screenshot 2

CJK script:
screenshot 3

Devanagari script:
screenshot 4

Bengali script:
screenshot 5

The water color difference is independent from this PR.

BTW: On older maps, usage of serif fonts is quite common.

@kocio-pl
Copy link
Collaborator

I also don't like serif fonts in western scripts, but could accept it if other scripts would gain something this way. However on these screenshots I see no change, so I'm against merging this code.

@sommerluk
Copy link
Collaborator Author

I see no change

It affects water features and landuse features. There is a difference in the screenshots, but of course more subtile than for the Latin regular vs italic.

@kocio-pl
Copy link
Collaborator

I'm closing it, because problems are visible, gains are subtle (if any) and there was no support from users of other scripts.

@kocio-pl kocio-pl closed this Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants