Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering natural=bare_rock earlier #2852

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Conversation

kocio-pl
Copy link
Collaborator

The area of a bare rock can be substantial - and lack of overlay pattern doesn't help to recognize what it is.

Area in Libya

z8
Before
hgoab9nm
After
nlzevzxd

z9
Before
vbapdvya
After
nub8piae

landcover.mss Outdated
[zoom >= 13] {
polygon-pattern-file: url('symbols/rock_overlay.png');
[way_pixels >= 4] { polygon-pattern-gamma: 0.75; }
[way_pixels >= 64] { polygon-pattern-gamma: 0.3; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need these two lines.

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the size is a good reason to render it earlier. A small forest might be more interesting than a huge basalt plateau.

But in general I'd like to render landuse earlier so 'approve' from my side (assuming you fix the polygon-pattern-gamma).

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 19, 2017

Fixed, thanks for spotting!

I'm not sure if the size is a good reason to render it earlier. A small forest might be more interesting than a huge basalt plateau.

IMO general map is for explaining the space - if there is something big and characteristic, it's more interesting than just "a land" (whatever it is - a forest, a water reservoir, a basalt or a sand).

We don't claim some continents are interesting/boring just because some things are more (or less) popular than on the other ones. We just show what is here - like the ice on Antarctica.

@dieterdreist
Copy link

dieterdreist commented Sep 19, 2017 via email

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 19, 2017

This is an information what this area is and it tells a lot of this place. But if we have some rendering for oasis (a transportation-blue/amenity-brown palm icon?), we can just start showing it early too, because it's POI and it should not interfere with any other environment.

Think of a picnic table in the forest. Table is POI, but it's good to know it's located in the forest, not just "on a land".

BTW: natural=oasis has just 109 instances and no wiki page, so we should probably wait until it gains some popularity, but then we can render them even from z8 if it makes sense.

@dieterdreist
Copy link

dieterdreist commented Sep 19, 2017 via email

@kocio-pl kocio-pl merged commit b3338b3 into gravitystorm:master Sep 21, 2017
@kocio-pl kocio-pl deleted the bare_rock branch September 21, 2017 11:56
@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Nov 4, 2017

The testing area has been retagged since then, but it seems to be useful area type (complementary to ice) on Antarctica, like here:

http://www.openstreetmap.org/#map=8/-77.696/161.381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants