New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering orange dots for gastronomy on z17 #3475

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@kocio-pl
Collaborator

kocio-pl commented Oct 22, 2018

Fixes #3410
Follow up to #2945

Changes proposed in this pull request:

  • Rendering orange dot for gastronomy objects on z17, because they are very popular and create visual clutter (excluding food court, which is bigger and less popular, it would be still rendered as full orange icon)
  • Removing night club from this category and showing it similar to other entertainment objects like cinema, since this is more about party than gastronomy, it's also much less popular and does not create clutter

Warsaw, Old Town, z17

Before

1agch66m

After

yo_jfsoy

@matthijsmelissen

This comment has been minimized.

Collaborator

matthijsmelissen commented Oct 23, 2018

Great work!

I would keep nightclub in by the way, it is not that different from a bar.

@kocio-pl

This comment has been minimized.

Collaborator

kocio-pl commented Oct 23, 2018

It typically includes bar, but as far as I know its primary function is dancing and some other venues and shows. I see it as hotel where you can eat something (typically breakfast), but its primary function is sleeping place.

@Tomasz-W

This comment has been minimized.

Tomasz-W commented Oct 23, 2018

+1 for moving amenity=nightclub to amenity-brown for the reasons given above.

@kocio-pl kocio-pl changed the title from Rendering orange dots for gastronomy on z17 [WIP] to Rendering orange dots for gastronomy on z17 Oct 26, 2018

@kocio-pl kocio-pl merged commit 9d16b99 into gravitystorm:master Oct 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kocio-pl kocio-pl deleted the kocio-pl:gastronomy-dot branch Oct 26, 2018

@Tomasz-W

This comment has been minimized.

Tomasz-W commented Oct 27, 2018

Looking forward to see a test renderings of blue dots for some of accomodation objects at z17 :) #3448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment