-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Index for Ferry Layers #3909
Conversation
Pull request gravitystorm#3727 introduced the new condition osm_id > 0 but did not update the condition for the indexes inteded to be used by the SQL queries of these layers.
The old index will still work. I wouldn't expect many ways to match the old index but not the one proposed here, so I'd expect the performance difference to be small. |
@pnorman - your comments suggest that this change would make a small but positive improvement in the indexes. Do you approve of this change, or are there problems? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this change to the indexes should be an improvement.
Operational costs of changing indexes |
Should it be merged now, for this release, or do you want this delayed until we have another PR that requires updating indexes? For example, we could merge it to the schema-changes branch. |
@pnorman - is it ok to merge this PR for the next release, or do we need to wait? |
I'm not sure why we need it, but if we're going to merge it, now is okay |
Let's ship it with the schema changes |
Plan is to merge this PR at the same time the |
I merged this in to schema_changes, so it'll get brought in to master when we merge that. |
Pull request #3727 introduced the new condition osm_id > 0 but did not update the condition for the indexes inteded to be used by the SQL queries of these layers.