Don't form areas from tags like building=no #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A tag like building=no shouldn't cause the object to be considered an area.
jeisenbe
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
I've tested an import and reviewed test renderings with this PR, and the changes to openstreetmap-carto.lua work as expected: for example, highway=pedestrian closed ways with building=no, amenity=no and similar values are not imported as polygons, unless there is also an area=yes or another tag that specifies a polygon.
I did not test the changes to scripts/lua/test.lua but I don't see any problems there.
|
Tests with highway=pedestrian closed ways before: And after: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #3611 (comment)
Checked by loading an extract and verifying that building=no with other polygon tags are still areas, and then loading just a building=no way