-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render oneway roads narrower #465
Closed
matthijsmelissen
wants to merge
7
commits into
gravitystorm:master
from
matthijsmelissen:oneway-widths
Closed
Render oneway roads narrower #465
matthijsmelissen
wants to merge
7
commits into
gravitystorm:master
from
matthijsmelissen:oneway-widths
Commits on Apr 9, 2014
-
Render oneway roads narrower than twoway roads for the types motorway, trunk, primary, secondary and tertiary. This is accomplished by making twoway motorways wider and oneway trunk/primary/secondary/tertiary roads narrower. More important road types are now always rendered wider than less important road types. Changes: - Twoway motorways are rendered wider - Oneway trunk/primary/secondary/tertiary roads are rendered narrower - Secondary is now narrower on z13/z14 - Tertiary_link is now rendered just like tertiary - Round line caps on tertiary and larger are removed on regular roads to prevent gravitystorm#83 All other road types are rendered as before. Further changes to the width of link roads are left for a future pull request. I tried to achieve the goal of making more important road types wider than less important ones while at the same time making as little changes to the roadsizes as possible. I think it would be worth for if someone with feeling for design has a closer look at the sizes as we have them now. It should be very easy to adapt now: one can just change the variables in the beginning of the style. I put the road sizes in a kind of table to make them more legible. If people think that's not practical, I can change it back to a list again. This pull request resolves gravitystorm#265 and gravitystorm#83 on Github and 1952 on trac.
Configuration menu - View commit details
-
Copy full SHA for 6ffb89a - Browse repository at this point
Copy the full SHA 6ffb89aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3b66e3 - Browse repository at this point
Copy the full SHA c3b66e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a256cb - Browse repository at this point
Copy the full SHA 3a256cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d67b7 - Browse repository at this point
Copy the full SHA 10d67b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c54827 - Browse repository at this point
Copy the full SHA 9c54827View commit details -
Configuration menu - View commit details
-
Copy full SHA for b105ca3 - Browse repository at this point
Copy the full SHA b105ca3View commit details
Commits on Apr 26, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 1706f39 - Browse repository at this point
Copy the full SHA 1706f39View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.