gw-random-fields.php: Fixed an issue with pages not getting hidden.
#626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious if this PR solves the same problem? |
Sorry for not replying to this. My github notifications are definitely a mess and totally mismanaged. Yes, it does seem to do the job! |
|
@saifsultanc Let's send them the code from David's draft PR until we get it merged into GP Randomizer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2152014628/44086?folderId=3808239
Summary
The next page requests weren't loading. On debugging, found a recursive/repeated call to
modify_target_pagewhich on repeating back at page number 2. Added the remove_filter for that to avoid the issue.Also confirmed that the pages that should be hidden (because no field) are in fact hidden.
Possible future improvements to look at: For a form with 8 pages and only 4 made visible, the page numbers would display something like 'Step 1 of 8' then 'Step 2 of 8' then 'Step 7 of 8' and then 'Step 8 of 8'. Could be made better with 'Step 1 of 4', then 'Step 2 of 4', then 'Step 3 of 4', and then 'Step 4 of 4'.