Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gppa-acf-repeater-mapper.php: Added support for custom values with ACF field property template. #821

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2576524151/65219/

Summary

When using the GPPA ACF Repeater Mapper snippet, static values set in the Choice Template are ignored.

Copy link

github-actions bot commented May 1, 2024

Fails
🚫

Commit message 'gppa-acf-repeater-mapper.php: Add support for custom values with ACF field property template.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

🚫

Commit message 'gppa-acf-repeater-mapper.php: Add support for custom values with ACF field property template.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

🚫

Commit message 'gppa-acf-repeater-mapper.php: Add support for custom values with ACF field property template.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against cb51522

Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending fixing up PHPCS issues

S&M using your existing PR title.

@saifsultanc saifsultanc changed the title gppa-acf-repeater-mapper.php: Add support for custom values with ACF field property template. gppa-acf-repeater-mapper.php: Added support for custom values with ACF field property template. May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants