gw-quantity-as-decimal.php: Added suppport for decimals in feed product quantity.
#835
Conversation
There was a problem hiding this comment.
Thanks for adding this! I have one request.
@spivurno, I'm also curious what your thoughts are on this. I saw that Barth modified the snippet and sent it as a Gist, but I'm wondering if this particular addition would be better in an experimental snippet instead?
| @@ -90,6 +93,114 @@ function modify_quantity_input_tag( $markup, $field, $value, $lead_id, $form_id | |||
| return $markup; | |||
| } | |||
|
|
|||
| function modify_submission_data( $submission_data, $feed, $form, $entry ) { | |||
There was a problem hiding this comment.
This method is pretty hefty, and I'm admittedly having a hard time following what exactly we're doing here.
The appears to be a copy and paste of get_order_data with some changes. Is that correct? If so, can you call that out and note what changes you made so if something changes upstream that breaks this snippet, we'll know what to update in the future?
|
@claygriffiths Given the scope of the change and the burden we're taking on by incorporating so much core code here, I'd be in favor of drafting this (or closing if that is preferred) until we can validate the need. |
|
@spivurno @claygriffiths I suggest we close this PR. |
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2592472572/65993?folderId=8114575
Summary
When the
GW_Quantity_Decimalsnippet is used to allow a decimal in the quantity input field, the incorrect price is sent to the payment gateway. This PR would fix the issue by allowing decimals for the feed product quantity.