fix(core): undefined operation entity from operationFailed (#2897)

graycoreio · Jul 5, 2024 · db8afb6 · db8afb6
1 parent 265d54a
commit db8afb6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/libs/core/state/src/operation/entity/adapter.spec.ts b/libs/core/state/src/operation/entity/adapter.spec.ts
@@ -190,6 +190,16 @@ describe('@daffodil/core/state | daffCreateOperationEntityStateAdapter', () => {
       result = adapter.operationFailed(entity.id, errors, adapter.list(entities, state));
     });
 
+    describe('when the entity does not exist in state', () => {
+      beforeEach(() => {
+        result = adapter.operationFailed(`not ${entity.id}`, errors, adapter.list(entities, state));
+      });
+
+      it('should not touch state', () => {
+        expect(result.entities[`not ${entity.id}`]).toBeUndefined();
+      });
+    });
+
     it('should indicate that the entity is in an error state', () => {
       expect(result.entities[entity.id].daffState).toEqual(DaffState.Error);
     });

diff --git a/libs/core/state/src/operation/entity/adapter.ts b/libs/core/state/src/operation/entity/adapter.ts
@@ -169,11 +169,11 @@ export class DaffOperationEntityStateAdapter<T extends DaffIdentifiable = DaffId
   }
 
   operationFailed<S extends DaffOperationEntityState<T> = DaffOperationEntityState<T>>(key: string, errors: DaffStateError[], state: S): S {
-    return this.adapter.upsertOne({
+    return state.entities[key] ? this.adapter.upsertOne({
       ...state.entities[key],
       daffState: DaffState.Error,
       daffErrors: errors,
-    }, state);
+    }, state) : state;
   }
 
   resetState<S extends DaffOperationEntityState<T> = DaffOperationEntityState<T>>(key: string, state: S): S {