Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): undefined operation entity from operationFailed #2897

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Calling operationFailed when the referenced entity does not exist in state causes a bogus entity to be set to the undefined key.

What is the new behavior?

Only entities that are in state will have their error states set.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@griest024 griest024 added package: core @daffodil/core layer: state This PR or issue is related to the redux state layer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Jul 5, 2024
@griest024 griest024 self-assigned this Jul 5, 2024
@griest024 griest024 requested a review from a team as a code owner July 5, 2024 18:30
@griest024 griest024 merged commit db8afb6 into graycoreio:develop Jul 5, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: core @daffodil/core status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant