Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(all): upgrade Angular to v10 #1229

Closed
wants to merge 79 commits into from
Closed

feat(all): upgrade Angular to v10 #1229

wants to merge 79 commits into from

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Jan 12, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@damienwebdev damienwebdev mentioned this pull request Jan 12, 2021
Closed
3 tasks
@griest024 griest024 changed the title Ng10 2 feat(all): upgrade Angular to v10 Jan 12, 2021
@griest024 griest024 force-pushed the ng10-2 branch 2 times, most recently from 8407696 to a955ae6 Compare January 12, 2021 19:36
@griest024 griest024 marked this pull request as ready for review January 12, 2021 20:43
@griest024 griest024 requested review from a team as code owners January 12, 2021 20:43
@griest024
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@griest024 griest024 force-pushed the ng10-2 branch 6 times, most recently from abb3d9d to dd26e20 Compare January 14, 2021 23:01
@lderrickable
Copy link
Contributor

lgtm

lderrickable
lderrickable previously approved these changes Jan 16, 2021
View reviewed changes
@griest024
chore(all): upgrade Angular to v10 package and dependencies
caddc23 
BREAKING CHANGE: Dropped support for Angular v8 and v9
@griest024
feat(all): pass generic type to ModuleWithProviders
65771c1
@griest024
chore(design): drop static: false from @ContentChild and @ViewChild
8597a18 
https://angular.io/guide/static-query-migration#why-do-i-have-to-specify-static-false-isnt-that-the-default

> In Angular version 9 and later, it will be safe to remove any {static: false} flags and we will do this cleanup for you in a schematic.
@griest024
chore(driver): remove DaffCoreTestingModule from Magento testing
3cca166
@griest024
feat(design): add Directive decorator to mixin
5c57d31
@griest024
build(demo,daffio,design-land): add component style budgets
0129883 
https://angular.io/guide/build#configure-size-budgets
@griest024
fix(demo): aot compatible driver map
dd284cc
@griest024
test(auth,geography): change response instead of spying validators
d5fb40d
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
test(navigation): fix injected types (#1229)
414797d
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
test(newsletter): fix injected types (#1229)
564aefe
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(paypal): add default generic types to transformer interface (#1229)
a94557f
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(paypal): update to support @apollo/client 3 and apollo-angular 2 (…
81c605d 
…#1229)
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
test(paypal): fix injected types (#1229)
204fe6f
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(product): update to support @apollo/client 3 and apollo-angular 2 (
714f63c 
#1229)
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(product): add typename to driver response models (#1229)
7a7c2c6
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
test(product): fix injected types and use individual spies instead of…
dc66f8b 
… spy objects (#1229)
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(order): update to support @apollo/client 3 and apollo-angular 2 (#…
64a941d 
…1229)
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(order): add typename to driver response models (#1229)
86dfb7f 
__typename must be grabbed in order to properly match fragments
`addTypename: true` with the cache forces flushed responses to match the query (which includes __typename)
flushed responses that do not have __typename will cause invariant errors
adding __typename on the response models makes it easier to stub out response objects in tests
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
test(order): fix injected types and use individual spies instead of s…
2f419d3 
…py objects (#1229)
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
test(contact,newsletter): fix page name assertion (#1229)
d70e72a
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
style(design-land,design): linting (#1229)
7abd132
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
chore(all): fix placeholder dependency names (#1229)
2590f3c
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(cart): add injection token types (#1229)
9e7289e
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(auth): add injection token types (#1229)
f8f8756
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(category): add injection token types (#1229)
3fd50a3
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(contact): add injection token types (#1229)
f8c313b
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(geography): add injection token types (#1229)
08010e9
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(newsletter): add injection token types (#1229)
525434f
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(paypal): add injection token types (#1229)
043a8db
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(product): add injection token types (#1229)
8e0e776
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
feat(authorizenet): add injection token types (#1229)
ebec1bc
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
chore(external-router): disable coverage reporting (#1229)
3396479
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
test(product): remove unused cart testing module from product test (#…
37321b2 
…1229)
damienwebdev pushed a commit that referenced this pull request Jan 20, 2021
@griest024 @damienwebdev
chore(deps): bump jasminewd2 (#1229)
16c7106
@damienwebdev
Copy link
Member

damienwebdev commented Jan 20, 2021 •
edited
Loading

Merged manually with a rebase to 16c7106.

@damienwebdev damienwebdev mentioned this pull request Jan 20, 2021
Closed
@griest024 griest024 deleted the ng10-2 branch January 21, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lderrickable lderrickable lderrickable left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@griest024 @lderrickable @damienwebdev