Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): create theming CSS custom properties #1836

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 20, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There's currently not an easy way to use common color variables.

Part of: #1880

What is the new behavior?

Create theming CSS custom properties for common and frequently used colors.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Sep 20, 2021
@xelaint xelaint self-assigned this Sep 20, 2021
@xelaint xelaint added this to In progress in The Design Library via automation Sep 20, 2021
@xelaint xelaint requested a review from a team as a code owner September 20, 2021 15:54
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The Design Library automation moved this from In progress to Reviewer approved Sep 20, 2021
@damienwebdev damienwebdev merged commit 1ee580e into develop Sep 20, 2021
The Design Library automation moved this from Reviewer approved to Done Sep 20, 2021
@damienwebdev damienwebdev deleted the theming-variables branch September 20, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants