Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seach,search-product): add @daffodil/search and @daffodil/search-product #1935

Closed
wants to merge 38 commits into from

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Dec 24, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

TODO:

  • category mage transform test
  • category mage test package
  • limit results
    • testing
    • in mem
    • tests
  • recent searches
  • incremental search
  • separate errors states for incremental and main

@griest024 griest024 added package: search @daffodil/search package: search-product @daffodil/search-product labels Dec 24, 2021
@griest024 griest024 force-pushed the feat/search/init branch 3 times, most recently from d501669 to 01d271b Compare December 27, 2021 21:25
@griest024 griest024 added the package: search-category @daffodil/search-category label Dec 27, 2021
@griest024 griest024 force-pushed the feat/search/init branch 3 times, most recently from b1e86ba to 15ce05d Compare December 30, 2021 21:48
@griest024
Copy link
Member Author

@damienwebdev I updated this. Changes are:

  • using schema-dts types
  • feature in-memory backends now actually perform a search in their respective backends
  • everything should have API docs now

@griest024 griest024 force-pushed the feat/search/init branch 3 times, most recently from 5c6d445 to 5b191ad Compare December 31, 2021 17:14
@griest024 griest024 marked this pull request as ready for review January 17, 2022 14:38
@griest024 griest024 requested review from a team as code owners January 17, 2022 14:38
@griest024 griest024 force-pushed the feat/search/init branch 2 times, most recently from 535776b to a363f73 Compare January 18, 2022 19:49
@griest024 griest024 force-pushed the feat/search/init branch 2 times, most recently from c3a171b to f94e0a3 Compare February 2, 2022 20:30
@griest024
Copy link
Member Author

need truncated magento fragments for product and category

product:

  • url
  • name
  • short_description
  • price_range
  • thumbnail
  • sku

@griest024
Copy link
Member Author

add autocomplete with limited results

@griest024
Copy link
Member Author

/azp cancel

@azure-pipelines
Copy link

Command 'cancel' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@griest024
Copy link
Member Author

superseded by #2149

@griest024 griest024 closed this Aug 3, 2022
@griest024 griest024 deleted the feat/search/init branch September 10, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: search @daffodil/search package: search-category @daffodil/search-category package: search-product @daffodil/search-product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant