-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: change Dolphin to use mage-OS repository by default #65
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to change the Venia URL, right?
PR is failing because 2.3.7 and magento/module-wishlist-sample-data have dependency conflict. This is happening because we don't have older versions of magento/module-wishlist-sample-data in mage-os mirror Here's the log for it: https://github.com/graycoreio/mage2docker/runs/7680790648?check_suite_focus=true#step:9:3809 |
I'll add the required |
The |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Dolphin by default uses adobe's repo to install magento. This imply in having to setup a magento account and creating an access key for anyone who want to use dolphin.
Fixes: #66
What is the new behavior?
Change the default repository to be mage-OS. Mage-OS is the open initiative to maintain magento. It provides a Magento mirror that requires no authorization
Does this PR introduce a breaking change?
Other information