Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: change Dolphin to use mage-OS repository by default #65

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

build: change Dolphin to use mage-OS repository by default #65

wants to merge 6 commits into from

Conversation

MateusDadalto
Copy link
Contributor

@MateusDadalto MateusDadalto commented Aug 4, 2022 •
edited by damienwebdev
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Dolphin by default uses adobe's repo to install magento. This imply in having to setup a magento account and creating an access key for anyone who want to use dolphin.

Fixes: #66

What is the new behavior?

Change the default repository to be mage-OS. Mage-OS is the open initiative to maintain magento. It provides a Magento mirror that requires no authorization

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

damienwebdev
damienwebdev requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to change the Venia URL, right?

docs/stories/dolphin.md Outdated Show resolved Hide resolved
@MateusDadalto
Copy link
Contributor Author

PR is failing because 2.3.7 and magento/module-wishlist-sample-data have dependency conflict. This is happening because we don't have older versions of magento/module-wishlist-sample-data in mage-os mirror

Here's the log for it: https://github.com/graycoreio/mage2docker/runs/7680790648?check_suite_focus=true#step:9:3809

@damienwebdev damienwebdev mentioned this pull request Aug 5, 2022
Open
@Vinai
Copy link

Vinai commented Aug 6, 2022

I'll add the required magento/module-wishlist-sample-data to the mirror repo.
Will let you know when it is available.

@Vinai
Copy link

Vinai commented Aug 6, 2022

The magento/module-wishlist-sample-data package is now available win the version 100.3.5, which has requirements matching Magento 2.3.7-p3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienwebdev damienwebdev damienwebdev requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for MageOS in Mage2Docker
3 participants
@MateusDadalto @Vinai @damienwebdev