Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(all): fixup failing CI pipeline #15

Merged
merged 1 commit into from
Aug 2, 2021
Merged

ci(all): fixup failing CI pipeline #15

merged 1 commit into from
Aug 2, 2021

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Aug 2, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

CI is broken for various reasons.

Fixes: N/A

What is the new behavior?

We've

  1. Pinned PHP/Composer/Magento versions more correctly for future-compatability.
  2. Now run integrations tests against tagged releases as opposed to directly against branches in Github.
  3. Cached composer across the pipeline, improving test runs by ~2minutes (down from 5).
  4. Matrixed across composer versions as well, because Magento versions didn't use to support composer 2.
  5. Moved down from ubuntu-latest to ubuntu-18.04 because of Magento 2.3's PHP constraint. We'll revert once it's EoL.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: we no longer test against php7.2. Please use it at your own risk.

Other information

@damienwebdev damienwebdev changed the title fixup ci ci(all): fixup failing CI pipeline Aug 2, 2021
We've

1. Pinned PHP/Composer/Magento versions more correctly for future-compatability.
2. Now run integrations tests against tagged releases as opposed to directly against branches in Github.
3. Cached composer across the pipeline, improving test runs by ~2minutes (down from 5).
4. Matrixed across composer versions as well, because Magento versions didn't use to support composer 2.
5. Moved down from `ubuntu-latest` to `ubuntu-18.04` because of Magento 2.3's PHP constraint. We'll revert once it's EoL.

BREAKING CHANGE: we no longer test against php7.2. Please use it at your own risk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant