Handle arbitrary::Error::IncorrectFormat #1
+17
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for stellar/rs-soroban-sdk#1141, the basic problem described stellar/rs-soroban-sdk#1140 (comment)
If
Arbitrary::arbitrary
receives bytes it can't use it may returnError::IncorrectFormat
. At present, if this happens the proptest will fail.This patch uses the
reject_local
mechanism on the proptest test runner to reject these cases and try again.reject_local
will eventually return an error if too many cases are rejected.(I think we can probably do something similar for the random bytes buffer size, automatically increasing the buffer if Arbitrary returns NotEnoughData, but I have not done that yet).