Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include limits.h #17

Closed
wants to merge 1 commit into from
Closed

include limits.h #17

wants to merge 1 commit into from

Conversation

ffontaine
Copy link

Include limits.h to avoid the following build failure:

poundctl.c: In function 'oi_getn':
poundctl.c:232:29: error: 'INT_MAX' undeclared (first use in this function)
  232 |   if (errno || n < 0 || n > INT_MAX)
      |                             ^~~~~~~

Fixes:

Include limits.h to avoid the following build failure:

poundctl.c: In function 'oi_getn':
poundctl.c:232:29: error: 'INT_MAX' undeclared (first use in this function)
  232 |   if (errno || n < 0 || n > INT_MAX)
      |                             ^~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/4edfffcd5d4383c57947d97139331e0bf2cb6155

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@graygnuorg
Copy link
Owner

Thanks, Fabrice. However, since such constants are used in multiple files, I believe it is best to include limits.h in the pound.h file, which I did in commit 05d4991.

@ffontaine
Copy link
Author

Sure closing this PR

@ffontaine ffontaine closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants