-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'NoneType' object has no attribute 'split' on certain maps #68
Comments
Ah I see. This was probably destined to be broken code. Of course not all maps have localized data for enUS. A better solution is needed here but in the mean time I will check to see if the currently used file exists before attempting to use it. This of course means that the your code shouldn't rely on the map meta-data if you are supporting non US map files. The replay.map_name attribute is the map name derived from the replay and not the map file. It will be more reliable. |
I am considering this closed. Support for map meta data outside of the enUS localization can be considered a feature request at this point. |
Cool, I tried the replay mentioned in this Issue and it no longer dies in this way. |
add support for 70154, bump to 1.3.0
Happens on several of my replays, including:
ggtracker.com/replays/205113/getreplay
guessing that
sometimes sets game_strings to None.
This causes sc2reader to die when parsing the replay.
sc2gears can't parse this one either.
2.2% of our replay sample can't parse because of this (12 out of 549).
The text was updated successfully, but these errors were encountered: