Merge pull request #33 from MBXSystems/hotfix/close-udp

Close UDPSocket when closing logger

Gemfile.lock

@@ -25,7 +25,7 @@ GEM
       nokogiri (= 1.5.10)
       rake
       rdoc
-    json (1.8.0)
+    json (1.8.2)
     jwt (0.1.8)
       multi_json (>= 1.5)
     metaclass (0.0.1)

lib/gelf/logger.rb

@@ -4,10 +4,6 @@ module LoggerCompatibility
 
     attr_accessor :formatter
 
-    # Does nothing.
-    def close
-    end
-
     # Use it like Logger#add... or better not to use at all.
     def add(level, message = nil, progname = nil, &block)
       progname ||= default_options['facility']

lib/gelf/notifier.rb

@@ -98,6 +98,11 @@ def enable
       @enabled = true
     end
 
+    # Closes sender
+    def close
+      @sender.close
+    end
+
     # Same as notify!, but rescues all exceptions (including +ArgumentError+)
     # and sends them instead.
     def notify(*args)

lib/gelf/ruby_sender.rb

@@ -16,5 +16,9 @@ def send_datagrams(datagrams)
         @socket.send(datagram, 0, host, port)
       end
     end
+
+    def close
+      @socket.close
+    end
   end
 end

test/test_logger.rb

@@ -209,5 +209,13 @@ class TestLogger < Test::Unit::TestCase
     should "have formatter attribute" do
       @logger.formatter
     end
+
+
+    context "close" do
+      should "close socket" do
+        @sender.expects(:close).once
+        @logger.close
+      end
+    end
   end
 end

test/test_notifier.rb

@@ -226,6 +226,13 @@ class MyNotifier < GELF::Notifier; end
       end
     end
 
+    context "close" do
+      should "close sender" do
+        @sender.expects(:close).once
+        @notifier.close
+      end
+    end
+
     context "when disabled" do
       setup do
         @notifier.disable