Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

Add Extractor page display issue #1686

Closed
henrikjohansen opened this issue Nov 12, 2015 · 4 comments
Closed

Add Extractor page display issue #1686

henrikjohansen opened this issue Nov 12, 2015 · 4 comments
Assignees
@edmundoa
Labels
bug extractors
Milestone
1.3.0

Comments

@henrikjohansen
Copy link

After upgrading to v1.2.2 the full_message field is no longer displayed correctly - instead the page only shows "full_message [object Object]"
@joschi
Copy link
Contributor

joschi commented Nov 16, 2015

Unfortunately (or rather fortunately) I can't reproduce this on Graylog 1.2.2.

@henrikjohansen Is the full_message field only invalid in some cases or all the time? Are those messages correctly stored in Elasticsearch, including a valid full_message document field?
Maybe some external GELF client already transmits those invalid contents ("[object Object]", which looks like the JavaScript notation of a stringified complex object).

@henrikjohansen
Copy link
Author

@joschi the full_message field is present and can also be selected as a field to run extractors against - it's merely a display issue.

screenshot from 2015-11-17 08-37-03

@joschi
Copy link
Contributor

joschi commented Nov 17, 2015

@henrikjohansen Ah, ok. It seems only to happen on the Extractor page. I've tried to reproduce the bug on the search page and on the streams page. Should've read the issue title in the first place. 😉

@joschi joschi added this to the 1.2.3 milestone Nov 17, 2015
@edmundoa edmundoa self-assigned this Nov 17, 2015
edmundoa pushed a commit that referenced this issue Nov 17, 2015
Do not double escape full_message field
ae2653a 
The full_message formatted field is already escaped on the server, so we
avoid escaping it again in the Javascript code.

Refs #1686
edmundoa referenced this issue in Graylog2/graylog2-server Nov 17, 2015
Fix Html serialization
ab7ca5c 
The JSON serialization of the formatted `full_message` field is not
working properly, returning an empty object. As we render those fields
in Javascript, we can safely return the string representation of that
Html.

Refs #1686
This was referenced Nov 17, 2015
Merged
Merged
joschi added a commit to Graylog2/graylog2-server that referenced this issue Nov 18, 2015
@joschi
Merge pull request #1569 from Graylog2/issue-1686-server
5c3a713 
Fix Html serialization in `FieldMapper#convertNewlinesToBr()`
Refs graylog-labs/graylog2-web-interface#1686
joschi added a commit to Graylog2/graylog2-server that referenced this issue Nov 18, 2015
@joschi
Merge pull request #1569 from Graylog2/issue-1686-server
1f3d55a 
Fix Html serialization in `FieldMapper#convertNewlinesToBr()`
Refs graylog-labs/graylog2-web-interface#1686
(cherry picked from commit 5c3a713)
joschi added a commit to Graylog2/graylog2-server that referenced this issue Nov 18, 2015
@joschi
Merge pull request #1569 from Graylog2/issue-1686-server
06c8bb2 
Fix Html serialization in `FieldMapper#convertNewlinesToBr()`
Refs graylog-labs/graylog2-web-interface#1686
(cherry picked from commit 5c3a713)
@joschi joschi modified the milestones: 1.2.3, 1.3.0 Nov 23, 2015
@edmundoa
Copy link
Contributor

This was fixed in the linked PRs, and also on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@edmundoa edmundoa

Labels
bug extractors
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@joschi @edmundoa @henrikjohansen