New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extractor page display issue #1686

Closed
henrikjohansen opened this Issue Nov 12, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@henrikjohansen

henrikjohansen commented Nov 12, 2015

After upgrading to v1.2.2 the full_message field is no longer displayed correctly - instead the page only shows "full_message [object Object]"

@joschi

This comment has been minimized.

Contributor

joschi commented Nov 16, 2015

Unfortunately (or rather fortunately) I can't reproduce this on Graylog 1.2.2.

@henrikjohansen Is the full_message field only invalid in some cases or all the time? Are those messages correctly stored in Elasticsearch, including a valid full_message document field?
Maybe some external GELF client already transmits those invalid contents ("[object Object]", which looks like the JavaScript notation of a stringified complex object).

@henrikjohansen

This comment has been minimized.

henrikjohansen commented Nov 17, 2015

@joschi the full_message field is present and can also be selected as a field to run extractors against - it's merely a display issue.

screenshot from 2015-11-17 08-37-03

@joschi

This comment has been minimized.

Contributor

joschi commented Nov 17, 2015

@henrikjohansen Ah, ok. It seems only to happen on the Extractor page. I've tried to reproduce the bug on the search page and on the streams page. Should've read the issue title in the first place. 😉

@joschi joschi added this to the 1.2.3 milestone Nov 17, 2015

@edmundoa edmundoa self-assigned this Nov 17, 2015

edmundoa added a commit that referenced this issue Nov 17, 2015

Do not double escape full_message field
The full_message formatted field is already escaped on the server, so we
avoid escaping it again in the Javascript code.

Refs #1686

edmundoa referenced this issue in Graylog2/graylog2-server Nov 17, 2015

Fix Html serialization
The JSON serialization of the formatted `full_message` field is not
working properly, returning an empty object. As we render those fields
in Javascript, we can safely return the string representation of that
Html.

Refs #1686

joschi added a commit to Graylog2/graylog2-server that referenced this issue Nov 18, 2015

Merge pull request #1569 from Graylog2/issue-1686-server
Fix Html serialization in `FieldMapper#convertNewlinesToBr()`
Refs graylog-labs/graylog2-web-interface#1686

joschi added a commit to Graylog2/graylog2-server that referenced this issue Nov 18, 2015

Merge pull request #1569 from Graylog2/issue-1686-server
Fix Html serialization in `FieldMapper#convertNewlinesToBr()`
Refs graylog-labs/graylog2-web-interface#1686
(cherry picked from commit 5c3a713)

joschi added a commit to Graylog2/graylog2-server that referenced this issue Nov 18, 2015

Merge pull request #1569 from Graylog2/issue-1686-server
Fix Html serialization in `FieldMapper#convertNewlinesToBr()`
Refs graylog-labs/graylog2-web-interface#1686
(cherry picked from commit 5c3a713)

@joschi joschi modified the milestones: 1.2.3, 1.3.0 Nov 23, 2015

@edmundoa

This comment has been minimized.

Member

edmundoa commented Nov 25, 2015

This was fixed in the linked PRs, and also on master.

@edmundoa edmundoa closed this Nov 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment