Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

Multiple fixes #113

Merged
merged 4 commits into from
May 19, 2013
Merged

Multiple fixes #113

merged 4 commits into from
May 19, 2013

Conversation

cheald
Copy link

@cheald cheald commented Mar 8, 2013

  • Fixed secret_token being set by default. Instead, raise an error and instruct the user in how to generate their own token.
  • Fixed multibyte string slicing bug in messages table view (for 1.9 only - is 1.8 supported?)
  • Added test and development environments to the example configuration files to make it easier for developers.
  • Minor: Updated Kaminari version to eliminate deprecated ActiveSupport::Concern usage, which was spamming up the logs with deprecation notices.

@lennartkoopmann
Copy link
Contributor

Thank you very much. Will merge tonight!

Most possibly not the test and development environments for the sample configs because they were removed on purpose as they were source of confusion for people setting it up.

Also notice that the tests are not supposed to run or succeed. They never were that good or complete and most of them were not changed for 0.10.0/0.11.0 releases.

This is one of the last Rails releases. I am already working on a complete rewrite using the Play Framework that is ready to grow and not end in such a mess that the current web interface is.

@cheald
Copy link
Author

cheald commented Mar 8, 2013

Yeah, I noticed that the tests weren't in working order. I did briefly entertain the thought of writing some new tests in rspec, but didn't want to complicate things too far!

lennartkoopmann pushed a commit that referenced this pull request May 19, 2013
@lennartkoopmann lennartkoopmann merged commit 8bb9152 into graylog-labs:develop May 19, 2013
lennartkoopmann pushed a commit that referenced this pull request May 19, 2013
making it more obvious what to change
@lennartkoopmann
Copy link
Contributor

Sorry for the delay. Will be included in soon to be release v0.12.0!

As already explained I reverted your changes to the environments in the example configuration files. Documentation updated regarding the secret token: http://support.torch.sh/help/kb/graylog2-web-interface/installing-graylog2-web-interface-on-debian-6

Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants