Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gatsby 5 #70

Open
leonburman opened this issue Nov 24, 2022 · 2 comments
Open

Support Gatsby 5 #70

leonburman opened this issue Nov 24, 2022 · 2 comments

Comments

@leonburman
Copy link

leonburman commented Nov 24, 2022

I'm hoping to upgrade to Gatsby v5 soon but this plugin doesn't currently support it.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: maclynn-gatsby@1.0.0
npm ERR! Found: gatsby@5.1.0
npm ERR! node_modules/gatsby
npm ERR!   gatsby@"^5.1.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer gatsby@"^2.12.1 || ^3.0.0 || ^4.0.0" from gatsby-plugin-loadable-components-ssr@4.3.2
npm ERR! node_modules/gatsby-plugin-loadable-components-ssr
npm ERR!   gatsby-plugin-loadable-components-ssr@"*" from the root project
@kszot-ref
Copy link

kszot-ref commented Jan 24, 2023

@leonburman Gatsby v5 is not specified as a peer dependency here, but if you force install it it seems to work fine (at least I didn't notice any issues in my project)

@danielholmes
Copy link

danielholmes commented Mar 2, 2023

The README states they don't intend to support it:

Loadable gregberge/loadable-components#718 and Gatsby v5 will require React 18. React 18 ships with React.lazy which performs the same code-splitting + SSR that we are accomplishing here. There are no plans to write compatibility for React 18 / Gatsby 5 with this plugin, so the migration path should be one to React.lazy. This should result in an overall simpler implementation, and should be considered a positive that this plugin will no longer be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants