Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get PHP 8 working #42

Merged
merged 8 commits into from
Apr 14, 2021
Merged

Get PHP 8 working #42

merged 8 commits into from
Apr 14, 2021

Conversation

h-bragg
Copy link
Collaborator

@h-bragg h-bragg commented Apr 12, 2021

PHP8.0

Changes taken from #39 (thanks @Seldaek!)

  • Resolves Support PHP 8 #40
  • Fixes a retry bug in write, where it will not reset the retry counter on a successful write
  • Updates dependencies to handle php8.0

Todo before release

  • create a pre-8 branch to handle any updates required
  • Tag the current version as a 1.x ?

@h-bragg
Copy link
Collaborator Author

h-bragg commented Apr 12, 2021

builds, just needs merging and releasing with new version. No idea why scrutinizer is unhappy 🤷‍♂️.

If you get a few seconds @biggianteye I will leave it to you to merge and tag to make these people happy.

@h-bragg h-bragg changed the title test php8 Get PHP 8 working Apr 14, 2021
@biggianteye biggianteye merged commit f8c2048 into master Apr 14, 2021
@biggianteye biggianteye deleted the php-8-test branch April 14, 2021 20:34
@biggianteye
Copy link
Contributor

No idea why scrutinizer is unhappy 🤷‍♂️.

No idea either, but restarting it worked. 🤷🏽

This is now merged and tagged. Cheers @h-bragg

@biggianteye biggianteye removed their request for review April 14, 2021 20:44
@Seldaek
Copy link

Seldaek commented Apr 15, 2021

Great, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PHP 8
3 participants