New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrutinizer #30
Scrutinizer #30
Conversation
For consistency with our other projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks generall good, you can do stuff with coverage without the extra file btw.
- vendor/bin/phpunit --coverage-clover=./tests/report/coverage.clover | ||
|
||
after_script: | ||
- ./build/coverage_to_scrutinizer.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed this to:
after_script:
- test -f ./tests/report/coverage.clover && (wget https://scrutinizer-ci.com/ocular.phar; php ocular.phar code-coverage:upload --format=php-clover ./tests/report/coverage.clover)
https://github.com/graze/dog-statsd/blob/master/.travis.yml#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. I see that now. I had an older copy of dog-statsd that I was looking at. The one-liner makes sense.
No functional changes.