Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrutinizer #30

Merged
merged 10 commits into from Jul 7, 2017
Merged

Scrutinizer #30

merged 10 commits into from Jul 7, 2017

Conversation

biggianteye
Copy link
Contributor

No functional changes.

  • Adding code linting via PHP Code Sniffer.
  • Fixing all errors generated by Code Sniffer.
  • Adding support for code coverage reporting.
  • Uploading coverage reports to Scrutinizer.

@biggianteye biggianteye merged commit 8d08d7f into master Jul 7, 2017
@biggianteye biggianteye deleted the scrutinizer branch July 7, 2017 10:25
Copy link
Contributor

@h-bragg h-bragg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generall good, you can do stuff with coverage without the extra file btw.

- vendor/bin/phpunit --coverage-clover=./tests/report/coverage.clover

after_script:
- ./build/coverage_to_scrutinizer.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed this to:

after_script:
  - test -f ./tests/report/coverage.clover && (wget https://scrutinizer-ci.com/ocular.phar; php ocular.phar code-coverage:upload --format=php-clover ./tests/report/coverage.clover)

https://github.com/graze/dog-statsd/blob/master/.travis.yml#L18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I see that now. I had an older copy of dog-statsd that I was looking at. The one-liner makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants