Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL Component function should automatically receive width, height in props (if not provided by user) coming from inheritence of the parent GL.Node/GL.Surface #35

Closed
gre opened this issue Dec 3, 2015 · 2 comments
Closed

GL Component function should automatically receive width, height in props (if not provided by user) coming from inheritence of the parent GL.Node/GL.Surface #35

gre opened this issue Dec 3, 2015 · 2 comments
Labels
feature priority:high
Milestone
2.1.0

Comments

@gre
Copy link
Owner

gre commented Dec 3, 2015

No description provided.

@gre gre added the feature label Dec 3, 2015
@gre
Copy link
Owner Author

gre commented Dec 20, 2015

better than this, providing a second "context" parameter

@gre gre modified the milestone: 2.1.0 Dec 20, 2015
gre added a commit that referenced this issue Dec 20, 2015
@gre
Add pixelRatio #37 and context #35
c60afe4
@gre
Copy link
Owner Author

gre commented Dec 29, 2015

Actually will probably go back to initial idea. width , height and pixelRatio can be inherited from parents and incoming props and unified in the function parameter. This simplify implementations and I see no reason to differentiate incoming props from parent context.
There will just be a naming convention on these special props.

@gre gre closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature priority:high
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@gre