Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop the "path" option support #67

Closed
gre opened this issue May 23, 2017 · 3 comments
Closed

drop the "path" option support #67

gre opened this issue May 23, 2017 · 3 comments
Assignees

Comments

@gre
Copy link
Owner

gre commented May 23, 2017

following up of #66 (comment) / #62 (comment)
need to deprecate "path" and release a major that drop it.

for moving files, use react-native-fs or CameraRoll.saveToCameraRoll

@brentvatne
Copy link
Contributor

👍 makes sense to deprecate it to me

@gre gre self-assigned this Aug 25, 2017
@gre
Copy link
Owner Author

gre commented Aug 25, 2017

at the same time, we should rename "file" to "tmpfile" to make it clear this is not going to be kept very long.
that way we can also deprecate any usage of that "file" at same time of "path"

gre added a commit that referenced this issue Aug 25, 2017
@gre
Copy link
Owner Author

gre commented Aug 25, 2017

fixed in v2

@gre gre closed this as completed Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants