Greasemonkey + Stylish = broken Add-ons interface

[WonderCsabo]

see comment 2

[arantius]

What version of Greasemonkey? I assume you're referring to the replacement for the "explore add-ons" message added in a9e37a3 which is newer than 0.9.2 and fixed in 5d9f423 ?

[WonderCsabo]

I used 04.13 nightly GM build, now using 04.15. The message is not present now, but the whole scripts section is gone from addons manager!

Edit: Oops, if i open scripts manager from toolbar element, the scripts show up in Stylish' userstyle section. Maybe Stylish and GM are interferecing. Checking with Stylish disabled now.

Edit2: Very weird:
Stylish disabled: no scripts section, if i open from toolbar element, the scrips show ups in extensions section...
It seems the overlay of AOM is messed up.

[arantius]

It seems the overlay of AOM is messed up.

I haven't looked yet, but my very strong guess is that Stylish is being very dirty about their overlaying, and breaking some part of the existing system that we rely upon. (They definitely did this in Firefox 3.)

[WonderCsabo]

I'm not sure about that. As i said, with Stylish disabled, GM is overlaying the extensions section! Also, Stylish is not changed since 02.26, despite GM nightly build... I'll do a regression range test.

[sizzlemctwizzle]

I wasn't able to reproduce this at all in FF4.0 and OSX. I tried it with both GM installed first and Stylish installed first. You aren't using some nightly version of Firefox are you? Also, what's your OS? Any other extensions installed?

[WonderCsabo]

I have lots of addons, but no others are overlaying AOM, just these two. Win7, Fx4.0 final. I'll do a test with a fresh profile, with only Stylish and GM nightly installed.

Edit: I tried in a fresh profile, i can reproduce the issue.

[sizzlemctwizzle]

Edit: I tried in a fresh profile, i can reproduce the issue.

Weird. I'm not getting anything like this. Must be a windows only issue. Did you try reinstalling Stylish?

[WonderCsabo]

For what reason? The issue exists even if no other extension except GM is present... It seems it's a GM issue.

[sizzlemctwizzle]

The issue exists even if no other extension except GM is present...

Really? That's very strange. Is it only the nightly build of GM that causes this? Have you tried the 0.9.2 AMO build?

[arantius]

Csabo:

Please provide Firefox version, Greasemonkey version, and a complete description of what you think is going on. As is, you've changed your story a number of times, and I've no longer any idea what problem you're trying to explain any longer.

[WonderCsabo]

Win7, Fx4.0, GM 04.15, Stylish 1.1.2

In fresh profile.

If only GM is present:

• default, there is no userscripts section
• if i open usercripts manager from toolbar element, the scripts show up in extensions section

If GM and Stylish is installed:

• default, there is no userscripts section
• if i open userscripts manager from toolbar element, the scripts show up in extensions section, sometimes in Stylish' userstyles section

With AMO version, or 04.13 nightly or earlier the issue is not present.

[WonderCsabo]

I still see this. :( Really no one can confirm? :S

[arantius]

Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0) Gecko/20100101 Firefox/4.0
Completely fresh profile.
Installed only: Greasemonkey nightly 2011.04.20, Stylish 1.1.2 (plus one script plus one style; things also looked OK before that)

I see what I expect:
https://picasaweb.google.com/lh/photo/PTprjdzwxHaKHdSyFo9n7Q?feat=directlink
https://picasaweb.google.com/lh/photo/AR-_qmtrY20Arc-TaRmkpw?feat=directlink

Again, I can try to test on Windows but I have to remember to do that at a point that I'm near a Windows machine.

Csabo: do you have any system-wide extensions (e.g. those that Skype or other software forces into Firefox) that would be in a fresh profile? Do you see anything in the error console?

[WonderCsabo]

The setup is same as yours, just on Windows:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

No system-wide extensions.

I see this error in Add-ons manager:

Error: non-defined entity
Source file: chrome://greasemonkey/content/addons4-overlay.xul
Row: 81, Column: 7
Sourcecode:

  <label value="&greasemonkey.youhavenoscripts;"/>

[sizzlemctwizzle]

Error: non-defined entity

Well there's your problem. I take it your locale isn't en-US? Anthony hasn't updated the greasemonkey.dtd for other locales. In other locales greasemonkey.youhavenoscripts is actually called greasemonkey.noscriptshere.

[arantius]

Ah! That makes it so obvious. New string, not translated, and you're not using en-US localization? I should be able to get that fixed in the next nightly then.

In other locales greasemonkey.youhavenoscripts is actually called greasemonkey.noscriptshere.

No, that's a new string. In the add-ons window, to actually say "no scripts installed" really truly none. The latter string is for the monkey menu, when there may be scripts installed, but there are definitely none that match the filter to be shown there.

[WonderCsabo]

Yeah, that's the problem! I removed the locales, and now everything is fine.

I'm sorry, i forgot to tell that i'm using a locale. I'm always using Hungarian locale, cause i'm the translator of it. Next time, i'll check the error console first, too. BTW, there was a bug just like this. Should i report these, our you always fix these eventually?

[arantius]

I usually intend when adding new strings to filter them through Babelzilla for translation, and in the short term add copies of the English strings so that things at least don't break. This time, clearly, I forgot. It's certainly worth adding an issue to note a "broken outside of en-US" state. But super helpful if we identify at the beginning that that's what's going on ;-)