"window is not defined" in getEditor #1409

Closed
Ventero opened this Issue Aug 29, 2011 · 0 comments

Projects

None yet

2 participants

@Ventero
Ventero commented Aug 29, 2011

As a result of moving getEditor into its own module, it doesn't have access to window in the call to filePicker.init anymore, which currently makes it impossible to choose an editor via the UI.

Steps to reproduce:

  1. Open the Greasemonkey preferences
  2. Click "Change Editor"

Expected result: File picker dialog to choose an editor opens
Observed result: Nothing happpens

As the docs say, the first parameter to filePicker.init has to be non-null, so I have no idea if there's a better fix than to just pass window through every call to openInEditor and getEditor.

Ah, missed util/getBrowserWindow.js.

@arantius arantius added a commit that closed this issue Sep 1, 2011
@arantius arantius Fix getEditor() module.
Both "window" and string bundle references were broken.

Fixes #1409
29558e2
@arantius arantius closed this in 29558e2 Sep 1, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment