Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update scripts when newer version is a valid script #2468

Closed
tiansh opened this issue Jan 15, 2017 · 1 comment
Closed

Only update scripts when newer version is a valid script #2468

tiansh opened this issue Jan 15, 2017 · 1 comment
Milestone

Comments

@tiansh
Copy link
Contributor

tiansh commented Jan 15, 2017

I hope greasemonkey could refuse updating a script if the newer version cannot pass syntax checking.
(Here, syntax checking means something like try { new Function(script_code); } catch (e) { /* not pass */ })

The story (why):
One of my user complain to me that my script stop working after recent updating. After I helped the user debug the issue, we found that the newer version he installed is not downloaded completely, which meanse there is only half of codes and even not a valid script. I'm just hosting my script on GitHub pages, and I'm not sure why this happened. But I hope greasemonkey may refuse update script if the script cannot pass syntax checking.
the user is using fx 50.1 with gm 3.9

@FranklinYu
Copy link
Contributor

I think providing an example may help, such as this scrupt (609 kB).

@arantius arantius modified the milestone: Bankruptcy Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants