TypeError: GM_util.getPreferredLocale is not a function (Firefox 54 + intl.locale.matchOS=true) #2488

Closed
jbeich opened this Issue Mar 12, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@jbeich

jbeich commented Mar 12, 2017

GM fails to install scripts on Nightly but when upgrading with some already installed the following errors shows up on console. matchOS check probably needs to be adjusted per bug 1337551 + bug 1344901. CC @zbraniecki just in case.

1489301732457   addons.manager  ERROR   Exception calling provider <unnamed-provider>.getAddonsByTypes: TypeError: GM_util.getPreferredLocale is not a function (chrome://greasemonkey-modules/content/script.js:148:9) JS Stack trace: getBestLocalization@script.js:148:9 < Script_getLocalizedDescription@script.js:156:20 < ScriptAddon@addons4.js:98:3 < ScriptAddonFactoryByScript@addons4.js:74:28 < AddonProvider_getAddonsByTypes/<@addons4.js:50:27 < AddonProvider_getAddonsByTypes@addons4.js:49:7 < callProviderAsync@AddonManager.jsm:294:12 < promiseCallProvider/<@AddonManager.jsm:318:53 < Promise@Promise-backend.js:390:5 < promiseCallProvider@AddonManager.jsm:317:10 < getAddonsByTypes/<@AddonManager.jsm:2510:36
@janekptacijarabaci

This comment has been minimized.

Show comment
Hide comment
@janekptacijarabaci

janekptacijarabaci Mar 12, 2017

Contributor

Thank you.

Contributor

janekptacijarabaci commented Mar 12, 2017

Thank you.

@zbraniecki

This comment has been minimized.

Show comment
Hide comment
@zbraniecki

zbraniecki Mar 13, 2017

I'm not sure why you want to get system locale as preferred one rather than app locale.

And if you, by any chance, do want an app locale, please, wait for bug 1346819 to land (hopefully today) and then use Services.locale.getAppLocaleAsLangTag.

Thank you and sorry for the trouble!

I'm not sure why you want to get system locale as preferred one rather than app locale.

And if you, by any chance, do want an app locale, please, wait for bug 1346819 to land (hopefully today) and then use Services.locale.getAppLocaleAsLangTag.

Thank you and sorry for the trouble!

@arantius

This comment has been minimized.

Show comment
Hide comment
@arantius

arantius Apr 25, 2017

Collaborator

I've just pushed version 3.11beta1: https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/versions/beta?page=1#version-3.11beta1

It would be very useful if you could install it and confirm that it fixes this issue.

Collaborator

arantius commented Apr 25, 2017

I've just pushed version 3.11beta1: https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/versions/beta?page=1#version-3.11beta1

It would be very useful if you could install it and confirm that it fixes this issue.

@arantius arantius closed this Apr 25, 2017

@jbeich

This comment has been minimized.

Show comment
Hide comment
@jbeich

jbeich Apr 25, 2017

I confirm, FF55 + intl.locale.matchOS=true works fine on GM 3.11beta1 unlike GM 3.10.

jbeich commented Apr 25, 2017

I confirm, FF55 + intl.locale.matchOS=true works fine on GM 3.11beta1 unlike GM 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment